Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation guidance mismatch #73

Open
hassaniazi opened this issue Aug 13, 2024 · 4 comments
Open

Installation guidance mismatch #73

hassaniazi opened this issue Aug 13, 2024 · 4 comments
Assignees

Comments

@hassaniazi
Copy link
Member

hassaniazi commented Aug 13, 2024

README here https://github.com/JGCRI/tethys?tab=readme-ov-file#installation says pip install tethys-downscale

but quickstarter here https://github.com/JGCRI/tethys/blob/main/notebooks/quickstarter.ipynb says pip install tethys-downscaling

Both may work, I haven't tested. Maybe we can be consistent.

@thurber
Copy link
Collaborator

thurber commented Aug 15, 2024

additionally, the download utility is looking for the module to be named just tethys rather than tethys-downscaling which is also definitely causing problems

@thurber thurber assigned thurber and hassaniazi and unassigned thurber Aug 15, 2024
@thurber
Copy link
Collaborator

thurber commented Aug 19, 2024

@hassaniazi can you branch your fixes for this off of dev and create a new pull request? also, i think we should stick with semver versioning, so instead of just 2.1 we'll want something more like 2.1.0. @crvernon, preference for the next version number?

@hassaniazi
Copy link
Member Author

totally, will do!

@hassaniazi
Copy link
Member Author

This is done, commit here: 28323aa

FYI for users who have already cloned the repo, I had to run python setup.py egg_info from terminal to update the package version from 2.1 to 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants