Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOSS review: README #77

Closed
znicholls opened this issue Jul 7, 2023 · 1 comment
Closed

JOSS review: README #77

znicholls opened this issue Jul 7, 2023 · 1 comment

Comments

@znicholls
Copy link

A few things in the README aren't super clear as to their meaning.

  • What does "To install pre-built run the following" mean? "To install pre-built, example data run the following"?
  • What does "For users that would like to generate the run the following" mean? "For users that would like to generate the full data, run the following?"
  • stitches.generate_pkg_data seems to also not exist, has it been re-named?

openjournals/joss-reviews#5525
@crvernon crvernon mentioned this issue Sep 21, 2023
Merged
@crvernon
Copy link
Member

This has been addressed in a PR here: #85

Also, stitches.generate_pkg_data should now be discoverable upon merge of the meta PR.

That PR will make it in with the other review changes in a meta PR shortly. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crvernon @znicholls