Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Is JCSDA still using jedi-tools-env / do we need the +excel variant for py-pandas? #1413

Open
climbfuji opened this issue Dec 12, 2024 · 3 comments · May be fixed by #1410
Open
Assignees
Labels
INFRA JEDI Infrastructure

Comments

@climbfuji
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

I am wondering if JCSDA is still using jedi-tools-env. Back in the days when I was at JCSDA, we used jedi-tools-env to run some of the GitHub admin jobs, for example managing labels across GitHub repositories, collecting GitHub statistics, ...

I don't recall exactly for which of these tasks, but I had to add a +excel variant to py-pandas for one of them. Now, the +excel variant is becoming problematic, since newer versions of py-pandas require py-python-calamina -> py-maturin -> rust as dependencies. This is the full rust, not just rust-bootstrap. And py-maturin doesn't compile with Intel Classic or Intel LLVM either.

Describe the solution you'd like

If we don't need it anymore, I'd like to get rid of the +excel variant for py-pandas. Even better, if jedi-tools-env is no longer needed (maybe/hopefully @eap is handling all of these tasks differently with Terraform nowadays?), I'd like to get rid of it entirely.

If none of this is possible, then we should modify the common package definitions such that the +excel variant is only used with the GCC compiler (which is also the only compiler that triggers the build of jedi-tools-env).

Additional context

See #831 (comment) for the PR that added the +excel variant.

@eap
Copy link
Collaborator

eap commented Dec 13, 2024

jedi-tools-env is still being used for github reporting and a couple other cases. That said, it would be easy enough to use CSVs instead of excel sheets and it's only being done this way because of historical momentum. I'm entirely comfortable removing this variant.

@climbfuji
Copy link
Collaborator Author

jedi-tools-env is still being used for github reporting and a couple other cases. That said, it would be easy enough to use CSVs instead of excel sheets and it's only being done this way because of historical momentum. I'm entirely comfortable removing this variant.

That's awesome to hear, thanks very much. I'll do that. It will trim down the number of packages by at least 5 or 10 just because of that (and allow us to update pandas).

@climbfuji
Copy link
Collaborator Author

I'll keep this open until the PR that turns off the variant +excel is merged.

@climbfuji climbfuji moved this from Todo to In Progress in spack-stack-1.9.0 (2024 Q4) Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants