Skip to content

Commit 382d8c3

Browse files
fix check_package_config.py for version-less package entries
1 parent 4bf1051 commit 382d8c3

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

util/check_package_config.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,17 +35,19 @@
3535
## Iterate over concretized packages
3636
for concrete_spec in spack_lock["concrete_specs"].values():
3737
concrete_name = concrete_spec["name"]
38+
# Ignore user-specified packages:
3839
if concrete_name in sys.argv[1:]:
3940
continue
4041
concrete_version = concrete_spec["version"]
4142
if concrete_name in packages_versions["packages"].keys():
4243
# Check whether concretized package has specified version from common/packages.yaml
43-
config_version = packages_versions["packages"][concrete_name]["version"][0]
44-
if concrete_version != config_version:
45-
iret = 1
46-
print(
47-
f"WARNING: '{concrete_name}' concretized version {concrete_version} does not match {config_version} specified in $SPACK_ENV/common/packages.yaml"
48-
)
44+
if "version" in packages_versions["packages"][concrete_name].keys():
45+
config_version = packages_versions["packages"][concrete_name]["version"][0]
46+
if concrete_version != config_version:
47+
iret = 1
48+
print(
49+
f"WARNING: '{concrete_name}' concretized version {concrete_version} does not match {config_version} specified in $SPACK_ENV/common/packages.yaml"
50+
)
4951
# Check whether concretized variants match settings from common/packages.yaml
5052
config_variants = packages_versions["packages"][concrete_name]["variants"].split()
5153
for config_variant in config_variants:

0 commit comments

Comments
 (0)