Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version number in HIRS binary SpcCoef files #47

Open
ADCollard opened this issue Jun 10, 2024 · 5 comments
Open

Fix version number in HIRS binary SpcCoef files #47

ADCollard opened this issue Jun 10, 2024 · 5 comments
Assignees

Comments

@ADCollard
Copy link

This is a standalone issue created following a comment in CRTM PR#42.

The HIRS SpcCoeff files have a range of version numbers, it is not clear what the numbers mean.

To be read in correctly the version number for these files should be 8.02, as larger numbers require the presence of the PolAngle. The current version numbers for HIRS cause the code to crash.

@ADCollard
Copy link
Author

Here is the version numbers in the current fix files:

/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs2_n06.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.02
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs2_n07.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.02
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs2_n08.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.02
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs2_n09.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.04
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs2_n10.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.04
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs2_n11.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.04
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs2_n12.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.04
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs2_n14.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.04
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs2_tirosn.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.02
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs2-UWS_n06.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.01
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs2-UWS_n07.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.01
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs2-UWS_n09.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.05
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs2-UWS_n10.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.05
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs2-UWS_n11.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.05
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs2-UWS_n12.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.05
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs2-UWS_n14.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.05
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs3_n15.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.04
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs3_n16.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.04
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs3_n17.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.04
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs3-UWS_n15.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.05
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs3-UWS_n16.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.05
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs3-UWS_n17.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.05
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs4_metop-a.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.04
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs4_metop-b.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.02
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs4_n18.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.04
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs4_n19.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.04
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs4-UWS_metop-a.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.06
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs4-UWS_metop-b.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.01
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs4-UWS_n18.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.05
/scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs4-UWS_n19.SpcCoeff.bin
 SpcCoeff RELEASE.VERSION:  8.05

@ADCollard
Copy link
Author

I used a modified version of SpcCoeff_Inspect.f90 to modify the version numbers that were causing the problems.

The modified files are on Hera at /scratch1/NCEPDEV/da/Andrew.Collard/git/CRTM_REL-2.4.0_emc/fix/SpcCoeff/Big_Endian/hirs_fix (big endian only).

@BenjaminTJohnson
Copy link
Collaborator

Currently in China, will review next week.

Thanks!

@imoradi
Copy link

imoradi commented Oct 8, 2024

@BenjaminTJohnson there is the same issue with 2.4.1 coefficients, at least, for amsua_metop-b when run it within global workflow.

@BenjaminTJohnson
Copy link
Collaborator

@imoradi fairly certain this is now fixed in the latest tarball for crtmv3,

fix_REL-3.1.1.2.tar.gz

https://bin.ssec.wisc.edu/pub/s4/CRTM/fix_REL-3.1.1.2.tgz

Would you mind having a look? These should work with older releases of CRTM, let me know if there are any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants