Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for v3.2, reference results/ in binary tarballs (e.g., fix_REL-3.2.x.x.tar.gz) should be all be in netcdf #186

Open
BenjaminTJohnson opened this issue Nov 15, 2024 · 3 comments
Assignees

Comments

@BenjaminTJohnson
Copy link
Contributor

currently only forward/test_Simple are netcdf by default.

Need to update each test code to switch to netCDF.

Also, forward/test_Simple.f90 produces an extra results file because rts_File gets redefined when the results don't match.
It's not even clear to me what the purpose of that bit of code is for.

@BenjaminTJohnson BenjaminTJohnson self-assigned this Nov 15, 2024
@BenjaminTJohnson
Copy link
Contributor Author

all input files to ctests need to be netcdf as well.

@BenjaminTJohnson
Copy link
Contributor Author

branch: feature/btj_all_ctests_netcdf
Also version numbers incremented to v3.2.0 throughout in this branch. Fun way to spend the day, checking off these boxes as I go.
.

  • ├── adjoint
  • │   ├── test_ClearSky
  • │   └── test_Simple
  • ├── forward
  • │   ├── test_AOD
  • │   ├── test_Aircraft
  • │   ├── test_ChannelSubset
  • │   ├── test_ClearSky
  • │   ├── test_OMPoverChannels
  • │   │   └── coefficients
  • │   ├── test_SOI
  • │   ├── test_SSU
  • │   ├── test_ScatteringSwitch
  • │   ├── test_Simple
  • │   │   └── coefficients
  • │   ├── test_User_Emissivity
  • │   ├── test_VerticalCoordinates
  • │   └── test_Zeeman
  • ├── incsrc
  • ├── k_matrix
  • │   ├── test_AOD
  • │   ├── test_ChannelSubset
  • │   ├── test_ClearSky
  • │   ├── test_SOI
  • │   ├── test_SSU
  • │   ├── test_ScatteringSwitch
  • │   ├── test_Simple
  • │   ├── test_User_Emissivity
  • │   ├── test_VerticalCoordinates
  • │   └── test_Zeeman
  • └── tangent_linear
  • ├── test_ClearSky
  • └── test_Simple

@BenjaminTJohnson
Copy link
Contributor Author

BenjaminTJohnson commented Nov 20, 2024

CRTM_Surface_*File (in CRTM_Surface_Define.f90) doesn't support netCDF. This support needs to be added, can be patterned after CRTM_RTSolution_*File . CRTM_Atmosphere has the same issue.

I'll work on both:

  • CRTM_Surface
    • InquireFile
    • ReadFile
    • WriteFile
  • CRTM_Atmosphere
    • InquireFile
    • ReadFile
    • WriteFile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant