Modded signs cant be written on.

[HoshiDevelopment]

I have confirmed that ...

• Arclight is up to date
• all dependencies are installed
• all plugins and mods are up to date
• unable to reproduce in Spigot
• unable to reproduce in Forge

Arclight version

arclight-fabric-1.21.1-1.0.0-SNAPSHOT

OS & Java versions

OS: Rocky Linux 8 Java: java version "21.0.2" 2024-01-16 LTS

Plugins and Mods

Mods:
Biomes o' Plenty

Description

When trying to use modded signs they dont work as expected and cause a huge error in the console.

[18:17:15 ERROR]: Failed to handle packet net.minecraft.class_2885@1090e8ca, suppressing error
java.lang.ClassCastException: class org.bukkit.craftbukkit.v1_21_R1.block.CraftBlockEntityState cannot be cast to class org.bukkit.block.Sign (org.bukkit.craftbukkit.v1_21_R1.block.CraftBlockEntityState and org.bukkit.block.Sign are in unnamed module of loader 'knot' @527740a2)
        at knot/org.bukkit.craftbukkit.v1_21_R1.event.CraftEventFactory.callPlayerSignOpenEvent(CraftEventFactoryMixin.java:300) ~[arclight-1.21.1-1.0.0-SNAPSHOT-4e387fc.jar:?]
        at knot/net.minecraft.class_2478.handler$bhn000$arclight$signEdit(SignBlockMixin.java:547) ~[server-intermediary.jar:?]
        at knot/net.minecraft.class_2478.method_49825(SignBlockMixin.java) ~[server-intermediary.jar:?]
        at knot/net.minecraft.class_1822.method_7710(class_1822.java:29) ~[server-intermediary.jar:?]
        at knot/net.minecraft.class_1747.method_7712(BlockItemMixin.java:89) ~[server-intermediary.jar:?]
        at knot/net.minecraft.class_1747.method_7884(BlockItemMixin.java:46) ~[server-intermediary.jar:?]
        at knot/net.minecraft.class_1799.method_7981(ItemStackMixin_Vanilla.java:1657) ~[server-intermediary.jar:?]
        at knot/net.minecraft.class_3225.method_14262(ServerPlayerGameMode_Vanilla.java:372) ~[server-intermediary.jar:?]
        at knot/net.minecraft.class_3244.method_12046(ServerGamePacketListenerImplMixin.java:1158) ~[server-intermediary.jar:?]
        at knot/net.minecraft.class_2885.method_12547(CPlayerTryUseItemOnBlockPacketMixin.java:42) ~[server-intermediary.jar:?]
        at knot/net.minecraft.class_2885.method_11054(CPlayerTryUseItemOnBlockPacketMixin.java:10) ~[server-intermediary.jar:?]
        at knot/net.minecraft.class_2600.md665911$arclight$lambda$ensureRunningOnSameThread$0$0(PacketThreadUtilMixin.java:538) ~[server-intermediary.jar:?]
        at knot/net.minecraft.class_3738.run(class_3738.java:18) ~[server-intermediary.jar:?]
        at knot/net.minecraft.class_1255.method_18859(BlockableEventLoopMixin.java:162) ~[server-intermediary.jar:?]
        at knot/net.minecraft.class_4093.method_18859(class_4093.java:23) ~[server-intermediary.jar:?]
        at knot/net.minecraft.server.MinecraftServer.method_24306(MinecraftServerMixin.java:864) ~[server-intermediary.jar:?]
        at knot/net.minecraft.server.MinecraftServer.method_18859(MinecraftServerMixin.java:173) ~[server-intermediary.jar:?]
        at knot/net.minecraft.class_1255.method_16075(BlockableEventLoopMixin.java:136) ~[server-intermediary.jar:?]
        at knot/net.minecraft.server.MinecraftServer.method_20415(MinecraftServerMixin.java:846) ~[server-intermediary.jar:?]
        at knot/net.minecraft.server.MinecraftServer.method_16075(MinecraftServerMixin.java:840) ~[server-intermediary.jar:?]
        at knot/net.minecraft.class_1255.method_5383(BlockableEventLoopMixin.java:121) ~[server-intermediary.jar:?]
        at knot/net.minecraft.server.MinecraftServer.method_16208(MinecraftServerMixin.java:814) ~[server-intermediary.jar:?]
        at knot/net.minecraft.server.MinecraftServer.method_29741(MinecraftServerMixin.java:702) ~[server-intermediary.jar:?]
        at knot/net.minecraft.server.MinecraftServer.method_29739(MinecraftServerMixin.java:281) ~[server-intermediary.jar:?]
        at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]

Step to reproduce

1. Install any mod with custom signs
2. Place Custom Sign
3. Sign exists, cant edit text, huge error in console

Logs

No response

Server pack link (Optional)

No response

[qyl27]

Please test whether it is fixed in a842e85.

[HoshiDevelopment]

Issue still semi persists. Players can now place and write on signs however some players still crash. Errors in console are as follows.

[14:05:34 INFO]: [STDERR]: java.lang.ClassCastException: class org.bukkit.craftbukkit.v1_21_R1.block.CraftBlockEntityState cannot be cast to class org.bukkit.block.Sign (org.bukkit.craftbukkit.v1_21_R1.block.CraftBlockEntityState and org.bukkit.block.Sign are in unnamed module of loader 'knot' @37374a5e)
[14:05:34 INFO]: [STDERR]:      at net.coreprotect.listener.block.BlockPlaceListener.onBlockPlace(BlockPlaceListener.java:113)
[14:05:34 INFO]: [STDERR]:      at knot//org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70)
[14:05:34 INFO]: [STDERR]:      at knot//org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:601)
[14:05:34 INFO]: [STDERR]:      at knot//org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:588)
[14:05:34 INFO]: [STDERR]:      at knot//org.bukkit.craftbukkit.v1_21_R1.event.CraftEventFactory.callBlockPlaceEvent(CraftEventFactoryMixin.java:463)
[14:05:34 INFO]: [STDERR]:      at knot//io.izzel.arclight.common.mod.server.event.ArclightEventFactory.onBlockPlace(ArclightEventFactory.java:135)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.class_1799.method_7981(ItemStackMixin_Vanilla.java:1660)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.class_3225.method_14262(ServerPlayerGameMode_Vanilla.java:375)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.class_3244.method_12046(ServerGamePacketListenerImplMixin.java:1158)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.class_2885.method_12547(CPlayerTryUseItemOnBlockPacketMixin.java:42)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.class_2885.method_11054(CPlayerTryUseItemOnBlockPacketMixin.java:10)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.class_2600.mdd04e84$arclight$lambda$ensureRunningOnSameThread$0$0(PacketThreadUtilMixin.java:538)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.class_3738.run(class_3738.java:18)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.class_1255.method_18859(BlockableEventLoopMixin.java:162)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.class_4093.method_18859(class_4093.java:23)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.server.MinecraftServer.method_24306(MinecraftServerMixin.java:864)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.server.MinecraftServer.method_18859(MinecraftServerMixin.java:173)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.class_1255.method_16075(BlockableEventLoopMixin.java:136)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.server.MinecraftServer.method_20415(MinecraftServerMixin.java:846)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.server.MinecraftServer.method_16075(MinecraftServerMixin.java:840)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.class_1255.method_5383(BlockableEventLoopMixin.java:121)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.server.MinecraftServer.method_16208(MinecraftServerMixin.java:814)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.server.MinecraftServer.method_29741(MinecraftServerMixin.java:702)
[14:05:34 INFO]: [STDERR]:      at knot//net.minecraft.server.MinecraftServer.method_29739(MinecraftServerMixin.java:281)
[14:05:34 INFO]: [STDERR]:      at java.base/java.lang.Thread.run(Thread.java:1583)

[HoshiDevelopment]

Upon further testing the crash appears to only be on hanging signs.

[qyl27]

Oh, thank you, I will fix it later.

[sj-hub9796]

ah, it's again CoreProtect.

[qyl27]

How do you place the hanging signs of BOP?
In my test, placing the hanging signs caused a client crash. (I have a PR fix it just now, Glitchfiend/BiomesOPlenty#2328 .)

[qyl27]

In another mod oh-the-biomes-weve-gone, both signs and hanging signs work correctly.

[qyl27]

Ok, finally I found the problem, it is related to CoreProtect. This plugin is designed for vanilla servers, and won't do any support for modded servers.
We recommend using the mod GriefLogger instead for your server. mods help mods : )

[InitAuther97]

A fabric replacement for CoreProtect can be found in QuiltServerTools/Ledger

[HoshiDevelopment]

Ok, finally I found the problem, it is related to CoreProtect. This plugin is designed for vanilla servers, and won't do any support for modded servers. We recommend using the mod GriefLogger instead for your server. mods help mods : )

Thank you! I will give this a try today

[HoshiDevelopment]

A fabric replacement for CoreProtect can be found in QuiltServerTools/Ledger

I have previously tried Ledger but it's not compatible with some of my mods.. thank you though