You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Small nitpicks over my full read over Contributing.md
# Objective
Fixes to Contributing file
- Lists more coherent: starting with capital letter and ending with point.
- Fixed a Typo.
- A clarification on approval aimed at newcomers.
- Reference links
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+35-32Lines changed: 35 additions & 32 deletions
Original file line number
Diff line number
Diff line change
@@ -3,7 +3,7 @@
3
3
Hey, so you're interested in contributing to Bevy!
4
4
Feel free to pitch in on whatever interests you and we'll be happy to help you contribute.
5
5
6
-
Check out our community's [Code of Conduct](https://github.com/bevyengine/bevy/blob/main/CODE_OF_CONDUCT.md) and feel free to say hi on [Discord](https://discord.gg/bevy) if you'd like.
6
+
Check out our community's [Code of Conduct](https://github.com/bevyengine/bevy/blob/main/CODE_OF_CONDUCT.md) and feel free to say hi on [Discord] if you'd like.
7
7
It's a nice place to chat about Bevy development, ask questions, and get to know the other contributors and users in a less formal setting.
8
8
9
9
Read on if you're looking for:
@@ -78,17 +78,17 @@ Check out the next section for details on how this plays out.
78
78
79
79
1. Have actively engaged with Bevy development.
80
80
2. Have demonstrated themselves to be polite and welcoming representatives of the project with an understanding of our goals and direction.
81
-
3. Have asked to join the Bevy Org. Reach out to @cart on Discord or email us at [email protected] if you are interested. Everyone is welcome to do this. We generally accept membership requests, so don't hesitate if you are interested!
81
+
3. Have asked to join the Bevy Org. Reach out to @cart on [Discord] or email us at [email protected] if you are interested. Everyone is welcome to do this. We generally accept membership requests, so don't hesitate if you are interested!
82
82
83
-
Some Bevy Org members are also Triage Team members. These people can label and close issues and PRs but do not have merge rights or any special authority within the community. Existing Org members can vist the Bevy Engine Org page and navigate to the Triage Team to request membership. Once again, if you are interested don't hesitate to apply. We generally accept membership requests.
83
+
All Bevy Org members are also Triage Team members. These people can label and close issues and PRs but do not have merge rights or any special authority within the community.
84
84
85
85
Merge rights within the org are relatively centralized: this requires a large amount of trust when it comes to ethics, technical ability, and ability to enforce consistent project direction.
86
86
87
87
The current structure is as follows:
88
88
89
89
*@cart is our project lead, and has final say on controversial decisions
90
90
* There is a small group of other maintainers (@alice-i-cecile, @mockersf and @superdump), who have merge rights but abide by the following rules:
91
-
* Trivial PRs can be merged without approvals
91
+
* Trivial PRs can be merged without approvals.
92
92
* Relatively uncontroversial PRs can be merged following approval from at least two other community members with appropriate expertise.
93
93
* Controversial PRs are added to a backlog for @cart to address once two maintainers agree that they are ready.
94
94
* If 45 days elapse without action on a controversial PR (approval, feedback or an explicit request to defer), they can be merged without project lead approval.
@@ -104,9 +104,9 @@ PRs that are deemed controversial will receive the `S-Controversial` label, and
104
104
105
105
PRs are trivial if there is no reasonable argument against them. This might include:
106
106
107
-
*fixing dead links
108
-
*removing dead code or dependencies
109
-
*typo and grammar fixes
107
+
*Fixing dead links.
108
+
*Removing dead code or dependencies.
109
+
*Typo and grammar fixes.
110
110
111
111
PRs are controversial if there is serious design discussion required, or a large impact to contributors or users. Factors that increase controversy include:
112
112
@@ -134,10 +134,10 @@ We track issues and pull requests that must be included in releases using [Miles
134
134
Most changes don't require much "process". If your change is relatively straightforward, just do the following:
135
135
136
136
1. A community member (that's you!) creates one of the following:
137
-
*[Discussion](https://github.com/bevyengine/bevy/discussions): An informal discussion with the community. This is the place to start if you want to propose a feature or specific implementation.
137
+
*[GitHub Discussions]: An informal discussion with the community. This is the place to start if you want to propose a feature or specific implementation.
138
138
*[Issue](https://github.com/bevyengine/bevy/issues): A formal way for us to track a bug or feature. Please look for duplicates before opening a new issue and consider starting with a Discussion.
139
139
*[Pull Request](https://github.com/bevyengine/bevy/pulls) (or PR for short): A request to merge code changes. This starts our "review process". You are welcome to start with a pull request, but consider starting with an Issue or Discussion for larger changes (or if you aren't certain about a design). We don't want anyone to waste their time on code that didn't have a chance to be merged! But conversely, sometimes PRs are the most efficient way to propose a change. Just use your own judgement here.
140
-
2. Other community members review and comment in an ad-hoc fashion. Active subject matter experts may be pulled into a thread using `@mentions`. If your PR has been quiet for a while and is ready for review, feel free to leave a message to "bump" the thread, or bring it up on Discord in an appropriate engine development channel.
140
+
2. Other community members review and comment in an ad-hoc fashion. Active subject matter experts may be pulled into a thread using `@mentions`. If your PR has been quiet for a while and is ready for review, feel free to leave a message to "bump" the thread, or bring it up on [Discord] in an appropriate engine development channel.
141
141
3. Once they're content with the pull request (design, code quality, documentation, tests), individual reviewers leave "Approved" reviews.
142
142
4. After consensus has been reached (typically two approvals from the community or one for extremely simple changes) and CI passes, the [S-Ready-For-Final-Review](https://github.com/bevyengine/bevy/issues?q=is%3Aopen+is%3Aissue+label%3AS-Ready-For-Final-Review) label is added.
143
143
5. When they find time, [someone with merge rights](#how-were-organized) performs a final code review and merges the PR using [Bors](https://bors.tech/) by typing `bors r+`.
@@ -147,7 +147,7 @@ Most changes don't require much "process". If your change is relatively straight
147
147
Individual contributors often lead major new features and reworks. However these changes require more design work and scrutiny. Complex changes like this tend to go through the following lifecycle:
148
148
149
149
1. A need or opportunity is identified and an issue is made, laying out the general problem.
150
-
2. As needed, this is discussed further on that issue thread, in cross-linked GitHub discussion threads, or on Discord in the Engine Development channels.
150
+
2. As needed, this is discussed further on that issue thread, in cross-linked [GitHub Discussion] threads, or on [Discord] in the Engine Development channels.
151
151
3. Either a Draft Pull Request or an RFC is made. As discussed in the [RFC repo](https://github.com/bevyengine/rfcs), complex features need RFCs, but these can be submitted before or after prototyping work has been started.
152
152
4. The community as a whole helps improve the Draft PR and/or RFC, leaving comments, making suggestions, and submitting pull requests to the original branch.
153
153
5. Once the RFC is merged and/or the Draft Pull Request is transitioned out of draft mode, the [normal change process outlined in the previous section](#making-changes-to-bevy) can begin.
@@ -160,20 +160,20 @@ But how can *you* help?
160
160
No matter your experience level with Bevy or Rust or your level of commitment, there are ways to meaningfully contribute.
161
161
Take a look at the sections that follow to pick a route (or five) that appeal to you.
162
162
163
-
If you ever find yourself at a loss for what to do, or in need of mentorship or advice on how to contribute to Bevy, feel free to ask in Discord and one of our more experienced community members will be happy to help.
163
+
If you ever find yourself at a loss for what to do, or in need of mentorship or advice on how to contribute to Bevy, feel free to ask in [Discord] and one of our more experienced community members will be happy to help.
164
164
165
165
### Battle-testing Bevy
166
166
167
167
Ultimately, Bevy is a tool that's designed to help people make cool games.
168
168
By using Bevy, you can help us catch bugs, prioritize new features, polish off the rough edges, and promote the project.
169
169
170
-
If you need help, don't hesitate to ask for help on [GitHub Discussions](https://github.com/bevyengine/bevy/discussions), [Discord](https://discord.gg/bevy), or [reddit](https://www.reddit.com/r/bevy). Generally you should prefer asking questions as Github Discussions as they are more searchable.
170
+
If you need help, don't hesitate to ask for help on [GitHub Discussions], [Discord], or [reddit](https://www.reddit.com/r/bevy). Generally you should prefer asking questions as [GitHub Discussions] as they are more searchable.
171
171
172
172
When you think you've found a bug, missing documentation, or a feature that would help you make better games, please [file an issue](https://github.com/bevyengine/bevy/issues/new/choose) on the main `bevy` repo.
173
173
174
174
Do your best to search for duplicate issues, but if you're unsure, open a new issue and link to other related issues on the thread you make.
175
175
176
-
Once you've made something that you're proud of, feel free to drop a link, video, or screenshot in `#showcase` on Discord!
176
+
Once you've made something that you're proud of, feel free to drop a link, video, or screenshot in `#showcase` on [Discord]!
177
177
If you release a game on [itch.io](https://itch.io/games/tag-bevy) we'd be thrilled if you tagged it with `bevy`.
178
178
179
179
### Teaching others
@@ -183,24 +183,24 @@ By helping others with their issues, and teaching them about Bevy, you will natu
183
183
184
184
Some of the best ways to do this are:
185
185
186
-
* Answering questions on [GitHub Discussions](https://github.com/bevyengine/bevy/discussions), [Discord](https://discord.gg/bevy), and [reddit](https://www.reddit.com/r/bevy).
187
-
* Writing tutorials, guides, and other informal documentation and sharing them on [Bevy Assets](https://github.com/bevyengine/bevy-assets)
188
-
* Streaming, writing blog posts about creating your game, and creating videos. Share these in the `#devlogs` channel on Discord!
186
+
* Answering questions on [GitHub Discussions], [Discord], and [reddit](https://www.reddit.com/r/bevy).
187
+
* Writing tutorials, guides, and other informal documentation and sharing them on [Bevy Assets](https://github.com/bevyengine/bevy-assets).
188
+
* Streaming, writing blog posts about creating your game, and creating videos. Share these in the `#devlogs` channel on [Discord]!
189
189
190
190
### Writing plugins
191
191
192
192
You can improve Bevy's ecosystem by building your own Bevy Plugins and crates.
193
193
194
194
Non-trivial, reusable functionality that works well with itself is a good candidate for a plugin.
195
-
If it's closer to a snippet or design pattern, you may want to share it with the community on Discord, Reddit, or GitHub Discussions instead.
195
+
If it's closer to a snippet or design pattern, you may want to share it with the community on [Discord], Reddit, or [GitHub Discussions] instead.
196
196
197
197
Check out our [plugin guidelines](https://github.com/bevyengine/bevy/blob/main/docs/plugins_guidelines.md) for helpful tips and patterns.
198
198
199
199
### Fixing bugs
200
200
201
201
Bugs in Bevy (or the associated website / book) are filed on the issue tracker using the [`C-Bug`](https://github.com/bevyengine/bevy/issues?q=is%3Aissue+is%3Aopen+label%3AC-Bug) label.
202
202
203
-
If you're looking for an easy place to start, take a look at the [`D-Good-First-Issue`](https://github.com/bevyengine/bevy/issues?q=is%3Aopen+is%3Aissue+label%3AD-Good-First-Issue) label, and feel free to ask questions on that issue's thread in question or on Discord.
203
+
If you're looking for an easy place to start, take a look at the [`D-Good-First-Issue`](https://github.com/bevyengine/bevy/issues?q=is%3Aopen+is%3Aissue+label%3AD-Good-First-Issue) label, and feel free to ask questions on that issue's thread in question or on [Discord].
204
204
You don't need anyone's permission to try fixing a bug or adding a simple feature, but stating that you'd like to tackle an issue can be helpful to avoid duplicated work.
205
205
206
206
When you make a pull request that fixes an issue, include a line that says `Fixes #X` (or "Closes"), where `X` is the issue number.
@@ -214,12 +214,12 @@ Bevy can always be safer, better tested, and more idiomatic.
214
214
Like every other large, rapidly developing open source library you've ever used, Bevy's documentation can always use improvement.
215
215
This is incredibly valuable, easily distributed work, but requires a bit of guidance:
216
216
217
-
*inaccurate documentation is worse than no documentation: prioritize fixing broken docs
218
-
* Bevy is remarkable unstable: before tackling a new major documentation project, check in with the community on Discord or GitHub (making an issue about specific missing docs is a great way to plan) about the stability of that feature and upcoming plans to save yourself heartache
219
-
*code documentation (doc examples and in the examples folder) is easier to maintain because the compiler will tell us when it breaks
220
-
*inline documentation should be technical and to the point. Link relevant examples or other explanations if broader context is useful.
221
-
*the Bevy book is hosted on the `bevy-website` repo and targeted towards beginners who are just getting to know Bevy (and perhaps Rust!)
222
-
*accepted RFCs are not documentation: they serve only as a record of accepted decisions
217
+
*Inaccurate documentation is worse than no documentation: prioritize fixing broken docs.
218
+
* Bevy is remarkably unstable: before tackling a new major documentation project, check in with the community on Discord or GitHub (making an issue about specific missing docs is a great way to plan) about the stability of that feature and upcoming plans to save yourself heartache.
219
+
*Code documentation (doc examples and in the examples folder) is easier to maintain because the compiler will tell us when it breaks.
220
+
*Inline documentation should be technical and to the point. Link relevant examples or other explanations if broader context is useful.
221
+
*The Bevy book is hosted on the `bevy-website` repo and targeted towards beginners who are just getting to know Bevy (and perhaps Rust!).
222
+
*Accepted RFCs are not documentation: they serve only as a record of accepted decisions.
223
223
224
224
[docs.rs](https://docs.rs/bevy) is built from out of the last release's documentation, which is written right in-line directly above the code it documents.
225
225
To view the current docs on `main` before you contribute, clone the `bevy` repo, and run `cargo doc --open`.
@@ -302,15 +302,18 @@ If you end up adding a new official Bevy crate to the `bevy` repo:
302
302
303
303
When contributing, please:
304
304
305
-
*try to loosely follow the workflow in [*How we work together*](#how-we-work-together)
306
-
*consult the [style guide](.github/contributing/engine_style_guide.md) to help keep our code base tidy
307
-
*explain what you're doing and why
308
-
*document new code with doc comments
309
-
*include clear, simple tests
310
-
*add or improve the examples when adding new user-facing functionality
311
-
*break work into digestible chunks
312
-
*ask for any help that you need!
305
+
*Try to loosely follow the workflow in [*How we work together*](#how-we-work-together).
306
+
*Consult the [style guide](.github/contributing/engine_style_guide.md) to help keep our code base tidy.
307
+
*Explain what you're doing and why.
308
+
*Document new code with doc comments.
309
+
*Include clear, simple tests.
310
+
*Add or improve the examples when adding new user-facing functionality.
311
+
*Break work into digestible chunks.
312
+
*Ask for any help that you need!
313
313
314
314
Your first PR will be merged in no time!
315
315
316
316
No matter how you're helping: thanks for contributing to Bevy!
0 commit comments