Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition for pending approvals #6

Open
IvanFon opened this issue Mar 30, 2020 · 1 comment
Open

Condition for pending approvals #6

IvanFon opened this issue Mar 30, 2020 · 1 comment
Labels
enhancement New feature or request proposal A proposed feature open for discussion.

Comments

@IvanFon
Copy link
Owner

IvanFon commented Mar 30, 2020

Is your feature request related to a problem? Please describe.
Applying labels when a PR is pending approvals.

Describe the solution you'd like
Condition based on number of required approvals.

{
  name: "requiredApprovals",
  "count": 1
}

OR

{
  name: "approved",
  "value": true
}

Describe alternatives you've considered
Still considering:

  • does the Github API support checking required # of approvals
  • is checking # of approvals a common use case, or is a boolean better? (I'm leaning towards the latter)
@IvanFon IvanFon added enhancement New feature or request proposal A proposed feature open for discussion. open for discussion and removed open for discussion labels Mar 30, 2020
@jbinda jbinda mentioned this issue Mar 30, 2020
9 tasks
@TGTGamer
Copy link

Implemented in #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request proposal A proposed feature open for discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants