From 4668f6246be7cf5a9bccb5d6ee2459e4bf4736f9 Mon Sep 17 00:00:00 2001 From: Matt Lubner Date: Mon, 4 Jun 2018 10:50:55 -0700 Subject: [PATCH] Remove mongodb port mapping MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Test suite no longer needs a “real” mongodb instance --- Changes.md | 1 - docker-compose-production.yml | 2 -- docker-compose.yml | 2 -- 3 files changed, 5 deletions(-) diff --git a/Changes.md b/Changes.md index 3f924f1..db5bccf 100644 --- a/Changes.md +++ b/Changes.md @@ -8,6 +8,5 @@ - Swap default Docker environment from production to development, to improve DX. - Eliminate production-mode inclusion of devDependencies, to keep production Docker image as light as possible and lower production-mode memory usage. - Explicitly volume-map all files into Docker container when in dev-mode. -- Restore mongodb port mapping, for test suite (temporary - this should be removed once the test suite properly uses an in-memory mock db). - Removed the --harmony-proxies flag from npm test, as it is no longer supported by nodejs. - Eliminate different markup warning between client/server during dev diff --git a/docker-compose-production.yml b/docker-compose-production.yml index 19857a1..1164641 100644 --- a/docker-compose-production.yml +++ b/docker-compose-production.yml @@ -14,8 +14,6 @@ services: MONGO_URL: mongodb://db:27017/mern-starter db: image: mongo:latest - ports: - - "27017:27017" volumes: - dbdata:/data/db volumes: diff --git a/docker-compose.yml b/docker-compose.yml index 20d6da1..b581c9c 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -29,8 +29,6 @@ services: tty: true db: image: mongo:latest - ports: - - "27017:27017" volumes: - dbdata:/data/db volumes: