-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect output for default workshop custom settings #495
Comments
Could you please provide an example of when the last Expected Output should be expected? I am unfamiliar with any situations where the Overwatch Workshop outputs a setting as an array with one element. |
Did some more experimenting with this, the expected output is produced specifically with WorkshopSettingCombo, when custom game settings are copied while the values are set to something other than default. |
I think all these LobbySettings issues can somehow be linked together and they're either being caused by the same or by a related bug. I haven't looked at the custom settings, but for the map and ult names I've been trying quite a few things for a while now and I am unable to find anything that has an actual effect on the compiled .ow script yet. There seems to be some functionality in place to replace certain characters like ( ) and , but I don't see it actually happening. I tried adding more of them at values, titles, resolved and translated names, but so far I don't see anything happening at all doing that. The only thing I found that has effect on things like map and ult names are the JSON files that come along with the binaries. Changing the names there will also change them in the compiled scripts, but they will also be different in the de-compiled scripts and I am not sure if that's gonna cause any other issues. I'll try to have another go at it later some time. |
After creating a workshop custom setting you can then specify the default values in customGameSettings.json, however the values this outputs are wrong.
customGameSettings.json:
Produces this output:
customGameSettings.json:
produces this output:
Expected output:
The text was updated successfully, but these errors were encountered: