DOCS: Can we remove INSTALL_EXISTING_CONFIG and DRUPAL_INSTALL_PROFILE?

[alxp]

The documentation, both here in the README and on the docs repo, says that to install from your own codebase you need to set two variables in .env. They are even already included in sample.env:

# If you're just demoing or are starting from scratch, use this.
INSTALL_EXISTING_CONFIG=false
DRUPAL_INSTALL_PROFILE=standard

# If you're installing from an existing codebase, uncomment this
#INSTALL_EXISTING_CONFIG=true
#DRUPAL_INSTALL_PROFILE=minimal

However, these variables do not seem to be used, and I think we can remove them from the docs - and possibly from the system.

Since we changed to use the starter site, the commands that installs islandora are:

production:

        docker compose exec -T drupal with-contenv bash -lc "drush si -y --existing-config minimal --account-pass '$(shell cat secrets/live/DRUPAL_DEFAULT_ACCOUNT_PASSWORD)'"

starter-finalize:

        docker compose exec -T drupal with-contenv bash -lc "drush si -y --existing-config minimal --account-pass '$(shell cat secrets/live/DRUPAL_DEFAULT_ACCOUNT_PASSWORD)'"

The variables INSTALL_EXISTING_CONFIG and DRUPAL_INSTALL_PROFILE do not factor in.

However, these variables may be used from within the containers (i.e. scripts from within buildkit?)

iMac:docker-compose aoneill$ grep INSTALL *
docker-compose.custom.yml:      DRUPAL_DEFAULT_INSTALL_EXISTING_CONFIG: "true"
docker-compose.drupal.yml:      DRUPAL_DEFAULT_PROFILE: ${DRUPAL_INSTALL_PROFILE}
docker-compose.local.yml:      DRUPAL_DEFAULT_INSTALL_EXISTING_CONFIG: ${INSTALL_EXISTING_CONFIG}
docker-compose.local.yml:      DRUPAL_DEFAULT_PROFILE: ${DRUPAL_INSTALL_PROFILE}
docker-compose.starter.yml:      DRUPAL_DEFAULT_INSTALL_EXISTING_CONFIG: ${INSTALL_EXISTING_CONFIG}
docker-compose.starter.yml:      DRUPAL_DEFAULT_PROFILE: ${DRUPAL_INSTALL_PROFILE}
docker-compose.starter_dev.yml:      DRUPAL_DEFAULT_INSTALL_EXISTING_CONFIG: ${INSTALL_EXISTING_CONFIG}
docker-compose.starter_dev.yml:      DRUPAL_DEFAULT_PROFILE: ${DRUPAL_INSTALL_PROFILE}

In utilities.sh, in function install_site, the variables used are INSTALL_EXISTING_CONFIG and PROFILE but I'm not sure if anything calls this function anymore?