From 7d704006f5cd5538361d464da68b81458941b1a6 Mon Sep 17 00:00:00 2001 From: Ishan09811 Date: Thu, 2 Jan 2025 19:16:39 +0530 Subject: [PATCH 1/3] Update vkma submodule --- app/libraries/vkma | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/libraries/vkma b/app/libraries/vkma index 936bc4b5..3bab6924 160000 --- a/app/libraries/vkma +++ b/app/libraries/vkma @@ -1 +1 @@ -Subproject commit 936bc4b57e7ffa5906a786735537c5493224e7d6 +Subproject commit 3bab6924988e5f19bf36586a496156cf72f70d9f From 844c5a1097c09d1ec979deaad7808e29a3984957 Mon Sep 17 00:00:00 2001 From: Ishan09811 <156402647+Ishan09811@users.noreply.github.com> Date: Fri, 3 Jan 2025 14:44:43 +0530 Subject: [PATCH 2/3] memory_manager: ``VMA_MEMORY_USAGE_CPU_ONLY`` is deprecated --- app/src/main/cpp/skyline/gpu/memory_manager.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/src/main/cpp/skyline/gpu/memory_manager.cpp b/app/src/main/cpp/skyline/gpu/memory_manager.cpp index 47b8d771..20fc6cb3 100644 --- a/app/src/main/cpp/skyline/gpu/memory_manager.cpp +++ b/app/src/main/cpp/skyline/gpu/memory_manager.cpp @@ -84,7 +84,8 @@ namespace skyline::gpu::memory { }; VmaAllocationCreateInfo allocationCreateInfo{ .flags = VMA_ALLOCATION_CREATE_MAPPED_BIT, - .usage = VMA_MEMORY_USAGE_CPU_ONLY, + .requiredFlags = VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT, + .preferredFlags = VK_MEMORY_PROPERTY_HOST_CACHED_BIT, // may increase performance }; VkBuffer buffer; From 9bd6d6747c6567d5d3ad5973ff3b0e35bc35872d Mon Sep 17 00:00:00 2001 From: Ishan09811 <156402647+Ishan09811@users.noreply.github.com> Date: Fri, 3 Jan 2025 14:50:18 +0530 Subject: [PATCH 3/3] memory_manager: VMA_MEMORY_USAGE_GPU_ONLY is also deprecated --- app/src/main/cpp/skyline/gpu/memory_manager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/cpp/skyline/gpu/memory_manager.cpp b/app/src/main/cpp/skyline/gpu/memory_manager.cpp index 20fc6cb3..e587ff85 100644 --- a/app/src/main/cpp/skyline/gpu/memory_manager.cpp +++ b/app/src/main/cpp/skyline/gpu/memory_manager.cpp @@ -120,7 +120,7 @@ namespace skyline::gpu::memory { Image MemoryManager::AllocateImage(const vk::ImageCreateInfo &createInfo) { VmaAllocationCreateInfo allocationCreateInfo{ - .usage = VMA_MEMORY_USAGE_GPU_ONLY, + .requiredFlags = VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT, }; VkImage image;