You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd rather offload this check to a more well tested library than doing a naive approach of just checking if it ends in .git and starts with https:// or git@, which wouldn't actually be accurate.
I assume the existing parsed object could just have isClonable: true or isClonable: false appended to the result.
The problem with this is that we can't know if it is clonable unless we actually make a request to the URL. Technically, I believe any url could eventually serve back a git repository.
Just a simple boolean to say if the string passed in can be used with
git clone
.Since there is so much variety in what is allowed:
I'd rather offload this check to a more well tested library than doing a naive approach of just checking if it ends in
.git
and starts withhttps://
orgit@
, which wouldn't actually be accurate.I assume the existing parsed object could just have
isClonable: true
orisClonable: false
appended to the result.But would also be fine with it being an appended method, like
.toString()
.The text was updated successfully, but these errors were encountered: