Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide means to get via properties file groupID, artifactid, and version for implementations of *Application class. #91

Open
rsearls opened this issue Sep 25, 2023 · 2 comments
Labels
triage This issue needs investigation to better define its scope and context

Comments

@rsearls
Copy link
Collaborator

rsearls commented Sep 25, 2023

A standard mechanism is needed for implementations of *Application class
to retrieve groupID, artifactid, and version from the standard (external)
properties file.

Example see file, demos/ws-bootable-jar-example/jaxws/src/test/java/org/jboss/jaxws/SoapWildflyBootableOpenShiftJarApplication.java
These lines should not be hard coded.

private String GROUPID = "org.jboss.intersmash";
private String ARTIFACTID = "jaxws";
private String VERSION = "0.0.1-SNAPSHOT"; 

The values should be retrievable from the properties file.

This enhancement needs to be generic so that any "key" can be specified
for retrieval.

@rsearls rsearls mentioned this issue Sep 25, 2023
10 tasks
@fabiobrz fabiobrz added the triage This issue needs investigation to better define its scope and context label Sep 25, 2023
@fabiobrz
Copy link
Member

Thanks for this issue, @rsearls - actually to me it looks like we don't need for the keys to be variable right?
I mean that this should be just a way for the runtime to be provided with G:A:V, hence I think only the values to be computed. BTW I think we should do something similar to https://github.com/Intersmash/intersmash/blob/main/deployments/intersmash-deployments-provider/src/main/java/org/jboss/intersmash/deployments/IntersmashSharedDeploymentsProperties.java

@rsearls
Copy link
Collaborator Author

rsearls commented Sep 26, 2023

Actually I think this should be a generic utility with a method, getProperty(key) and
getProperties() which returns a map of key/value pairs. This will allow users to more easily customize the *Application classes.

Why not consider using some MicroProfile impl.

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Sep 19, 2024
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2024
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Oct 19, 2024
@fabiobrz fabiobrz reopened this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage This issue needs investigation to better define its scope and context
Projects
None yet
Development

No branches or pull requests

2 participants