Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisioner test coverage overlapping #47

Open
fabiobrz opened this issue May 12, 2023 · 1 comment
Open

Provisioner test coverage overlapping #47

fabiobrz opened this issue May 12, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@fabiobrz
Copy link
Member

fabiobrz commented May 12, 2023

We have some overlapping in provisioning test coverage. Mostly in ProvisionerCleanupTestCase vs. *ProvisionerTest::basicProvisioningTest.

ProvisionerCleanupTestCase::undeploy is expected to be testing the full lifecycle (configure->predeploy->deploy->postUndeploy->dismiss) for each operator in order to verify that the namespace is left clean after it. Currently this is implemented to work just for a few provisioners, but we want for such test coverage to be applied to all of the supported provisioners.

On the other side, almost each provisioner is also tested for it's lifecycle to be properly working by a *ProvisionerTest::basicProvisioningTest, e.g.: ActiveMQOperatorProvisionerTest::basicProvisioningTest.

Optimizing this by removing the overlapping would make the test suite run faster.


  • Environment: testsuite
  • Steps to reproduce: N/A
@fabiobrz fabiobrz added the enhancement New feature or request label May 13, 2023
@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Sep 19, 2024
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2024
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Oct 19, 2024
@fabiobrz fabiobrz reopened this Oct 19, 2024
Copy link

dosubot bot commented Jan 20, 2025

Hi, @fabiobrz. I'm Dosu, and I'm helping the intersmash team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • The issue highlights overlapping test coverage in the provisioning tests.
  • Redundancy exists between ProvisionerCleanupTestCase and *ProvisionerTest::basicProvisioningTest.
  • The goal is to optimize the test suite by removing this overlap to improve efficiency.
  • No comments or further activity have been made on this issue.

Next Steps:

  • Please confirm if this issue is still relevant to the latest version of the intersmash repository by commenting on this issue.
  • If no further activity occurs, this issue will be automatically closed in 30 days.

Thank you for your understanding and contribution!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jan 20, 2025
@fabiobrz fabiobrz removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant