Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deployments module altogether? #112

Open
fabiobrz opened this issue Nov 18, 2023 · 0 comments
Open

Remove the deployments module altogether? #112

fabiobrz opened this issue Nov 18, 2023 · 0 comments
Labels
triage This issue needs investigation to better define its scope and context

Comments

@fabiobrz
Copy link
Member

fabiobrz commented Nov 18, 2023

The deployments module seems to have no more rationale here:

  • it was designed originally in the monolithic version in order to reuse application servers (EAP/WildFly) deployments.
  • it was then kept in the internal version of the library in order to let both the demos submodule and integration tests depend on them.

Both the above are not requirements here in Intersmash, since there's a testsuite module which could contain the deployments sources.
BTW the testsuite filesystem structure could result in something more similar to the way currently implemented integration tests look like (e.g.: see existing WIldFly/Arquillian tests in the WIldFly testsuite).
A starting point could be what has been done here in Intersmash demos.

  • Environment: testsuite
  • Steps to reproduce: N/A
@fabiobrz fabiobrz added the triage This issue needs investigation to better define its scope and context label Nov 18, 2023
@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Sep 19, 2024
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2024
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Oct 19, 2024
@fabiobrz fabiobrz reopened this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage This issue needs investigation to better define its scope and context
Projects
None yet
Development

No branches or pull requests

1 participant