Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plutus Core spec for Batch 4 inconsistent with conformance tests #6761

Closed
nielstron opened this issue Dec 21, 2024 · 3 comments
Closed

Plutus Core spec for Batch 4 inconsistent with conformance tests #6761

nielstron opened this issue Dec 21, 2024 · 3 comments

Comments

@nielstron
Copy link
Contributor

nielstron commented Dec 21, 2024

Summary

The plutus core spec of Batch 4, Note 1 contains: "An integer width argument 𝑀 with 0 ≀ 𝑀 < 8192"
The conformance test /builtin/semantics/integerToByteString/big-endian/bounded/max-input-fits-max-width contradicts this by providing width 8192 explicitly.

Also the spec for ByteStringToInteger is [πš‹πš˜πš˜πš•, πš‹πš’πšπšŽπšœπšπš›πš’πš—πš] β†’ πš‹πš’πšπšŽπšœπšπš›πš’πš—πš but should be [πš‹πš˜πš˜πš•, πš‹πš’πšπšŽπšœπšπš›πš’πš—πš] β†’ integer

@nielstron nielstron added the bug label Dec 21, 2024
@github-actions github-actions bot added the status: needs triage GH issues that requires triage label Dec 21, 2024
@kwxm kwxm added status: triaged and removed status: needs triage GH issues that requires triage labels Dec 23, 2024
@kwxm
Copy link
Contributor

kwxm commented Dec 23, 2024

Thanks for pointing those out. You're correct about both of them. The width check is done here and indeed it only fails if the length is strictly greater than 8192. We'll fix these shortly.

kwxm added a commit that referenced this issue Dec 23, 2024
@kwxm
Copy link
Contributor

kwxm commented Dec 23, 2024

I think these should be fixed by #6762.

kwxm added a commit that referenced this issue Dec 24, 2024
@effectfully
Copy link
Contributor

I think these should be fixed by #6762.

I'm closing the issue then. Please reopen if something's still off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants