add Show instance for HardForkLedgerConfig (#1488)

# Description

Adds a `Show` instance for `HardForkLedgerConfig`

Fixes #1414

Author: fraser-iohk

ouroboros-consensus-cardano/ouroboros-consensus-cardano.cabal

@@ -439,6 +439,7 @@ test-suite cardano-test
     Test.Consensus.Cardano.MiniProtocol.LocalTxSubmission.ByteStringTxParser
     Test.Consensus.Cardano.MiniProtocol.LocalTxSubmission.Server
     Test.Consensus.Cardano.Serialisation
+    Test.Consensus.Cardano.Show
     Test.Consensus.Cardano.SupportedNetworkProtocolVersion
     Test.Consensus.Cardano.SupportsSanityCheck
     Test.Consensus.Cardano.Translation

ouroboros-consensus-cardano/src/byron/Ouroboros/Consensus/Byron/ByronHFC.hs

@@ -259,7 +259,7 @@ data ByronPartialLedgerConfig = ByronPartialLedgerConfig {
       byronLedgerConfig    :: !(LedgerConfig ByronBlock)
     , byronTriggerHardFork :: !TriggerHardFork
     }
-  deriving (Generic, NoThunks)
+  deriving (Show, Generic, NoThunks)
 
 instance HasPartialLedgerConfig ByronBlock where
 

ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/Block.hs

@@ -44,7 +44,7 @@ import           Cardano.Ledger.Binary (Annotator (..), DecCBOR (..),
 import qualified Cardano.Ledger.Binary.Plain as Plain
 import           Cardano.Ledger.Core as SL (eraDecoder, eraProtVerLow,
                      toEraCBOR)
-import qualified Cardano.Ledger.Core as SL (hashTxSeq)
+import qualified Cardano.Ledger.Core as SL (TranslationContext, hashTxSeq)
 import           Cardano.Ledger.Hashes (HASH)
 import qualified Cardano.Ledger.Shelley.API as SL
 import           Cardano.Protocol.Crypto (Crypto)
@@ -89,6 +89,7 @@ class
   , EncCBOR (ShelleyProtocolHeader proto)
   , DecCBOR (Annotator (ShelleyProtocolHeader proto))
   , Show (CannotForgeError proto)
+  , Show (SL.TranslationContext era)
     -- Currently the chain select view is identical
     -- Era and proto crypto must coincide
   , SelectView proto ~ PraosChainSelectView (ProtoCrypto proto)

ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/Ledger.hs

@@ -195,6 +195,8 @@ data ShelleyPartialLedgerConfig era = ShelleyPartialLedgerConfig {
     }
   deriving (Generic)
 
+deriving instance Show (ShelleyLedgerConfig era) => Show (ShelleyPartialLedgerConfig era)
+
 deriving instance (NoThunks (Core.TranslationContext era), Core.Era era) =>
     NoThunks (ShelleyPartialLedgerConfig era)
 

ouroboros-consensus-cardano/test/cardano-test/Main.hs

@@ -5,6 +5,7 @@ import qualified Test.Consensus.Cardano.DiffusionPipelining
 import qualified Test.Consensus.Cardano.Golden
 import qualified Test.Consensus.Cardano.MiniProtocol.LocalTxSubmission.Server
 import qualified Test.Consensus.Cardano.Serialisation (tests)
+import qualified Test.Consensus.Cardano.Show ()
 import qualified Test.Consensus.Cardano.SupportedNetworkProtocolVersion
 import qualified Test.Consensus.Cardano.SupportsSanityCheck
 import qualified Test.Consensus.Cardano.Translation (tests)

ouroboros-consensus-cardano/test/cardano-test/Test/Consensus/Cardano/Show.hs

@@ -0,0 +1,9 @@
+module Test.Consensus.Cardano.Show () where
+
+import           Ouroboros.Consensus.Cardano ()
+import           Ouroboros.Consensus.Cardano.Block
+import           Ouroboros.Consensus.Shelley.Ledger.SupportsProtocol ()
+
+-- | This definition exists solely to ensure that 'CardanoLedgerConfig' has a working 'Show' instance that isn't accidentally removed or broken in future
+_showCardanoLedgerConfig :: CardanoLedgerConfig StandardCrypto -> String
+_showCardanoLedgerConfig = show

ouroboros-consensus-diffusion/test/consensus-test/Test/Consensus/HardFork/Combinator/A.hs

@@ -226,6 +226,7 @@ data PartialLedgerConfigA = LCfgA {
     , lcfgA_systemStart :: SystemStart
     , lcfgA_forgeTxs    :: Map SlotNo [GenTx BlockA]
     }
+  deriving Show
   deriving NoThunks via OnlyCheckWhnfNamed "LCfgA" PartialLedgerConfigA
   deriving Generic
   deriving Serialise

ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/HardFork/Combinator/AcrossEras.hs

@@ -350,6 +350,9 @@ deriving via LiftNS WrapTipInfo               xs instance CanHardFork xs => Show
 deriving via LiftNS WrapValidatedGenTx        xs instance CanHardFork xs => Show (OneEraValidatedGenTx        xs)
 deriving via LiftNS WrapValidationErr         xs instance CanHardFork xs => Show (OneEraValidationErr         xs)
 
+deriving instance Show (PartialLedgerConfig xs) => Show (WrapPartialLedgerConfig xs)
+deriving via LiftNP WrapPartialLedgerConfig xs instance CanHardFork xs => Show (PerEraLedgerConfig xs)
+
 deriving via LiftMismatch SingleEraInfo LedgerEraInfo xs instance All SingleEraBlock xs => Eq   (MismatchEraInfo xs)
 deriving via LiftMismatch SingleEraInfo LedgerEraInfo xs instance All SingleEraBlock xs => Show (MismatchEraInfo xs)
 

ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/HardFork/Combinator/Basics.hs

@@ -9,6 +9,7 @@
 {-# LANGUAGE StandaloneDeriving #-}
 {-# LANGUAGE TypeApplications #-}
 {-# LANGUAGE TypeFamilies #-}
+{-# LANGUAGE UndecidableInstances #-}
 
 module Ouroboros.Consensus.HardFork.Combinator.Basics (
     -- * Hard fork protocol, block, and ledger state
@@ -139,6 +140,7 @@ data HardForkLedgerConfig xs = HardForkLedgerConfig {
     }
   deriving (Generic)
 
+deriving instance Show (PerEraLedgerConfig xs) => Show (HardForkLedgerConfig xs)
 instance CanHardFork xs => NoThunks (HardForkLedgerConfig xs)
 
 type instance LedgerCfg (LedgerState (HardForkBlock xs)) = HardForkLedgerConfig xs

ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/HardFork/Combinator/PartialConfig.hs

@@ -68,6 +68,7 @@ class ( ConsensusProtocol p
 
 -- | Partial ledger config
 class ( UpdateLedger blk
+      , Show (PartialLedgerConfig blk)
       , NoThunks (PartialLedgerConfig blk)
       ) => HasPartialLedgerConfig blk where
   type PartialLedgerConfig blk :: Type

ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Ledger/Dual.hs

@@ -238,13 +238,15 @@ class (
       , CommonProtocolParams   m
       , HasTxId (GenTx         m)
       , Show (ApplyTxErr       m)
+      , Show (LedgerConfig     m)
 
         -- Requirements on the auxiliary block
         -- No 'LedgerSupportsProtocol' for @a@!
       , Typeable                a
       , UpdateLedger            a
       , LedgerSupportsMempool   a
       , Show (ApplyTxErr        a)
+      , Show (LedgerConfig      a)
       , NoThunks (LedgerConfig  a)
       , NoThunks (CodecConfig   a)
       , NoThunks (StorageConfig a)
@@ -334,6 +336,8 @@ data DualLedgerConfig m a = DualLedgerConfig {
     }
   deriving NoThunks via AllowThunk (DualLedgerConfig m a)
 
+deriving instance (Show (LedgerConfig m), Show (LedgerConfig a)) => Show (DualLedgerConfig m a)
+
 type instance LedgerCfg (LedgerState (DualBlock m a)) = DualLedgerConfig m a
 
 instance Bridge m a => HasPartialLedgerConfig (DualBlock m a)