Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Use stake key for proposal forum identity #1810

Closed
Ryun1 opened this issue Aug 23, 2024 · 3 comments
Closed

🐛 Use stake key for proposal forum identity #1810

Ryun1 opened this issue Aug 23, 2024 · 3 comments
Assignees
Labels
🐛 Bug Something isn't working 📜 Proposal Pillar

Comments

@Ryun1
Copy link
Member

Ryun1 commented Aug 23, 2024

Area

Proposal Pillar

Domain

sanchogov.tools

Which wallet were you using?

demos 1.8.2

Context

When authenticating users for proposal discussion forum they sign data with their payment key.

This implies to me that we are using payment keys to identify users, this is probably not ideal
Some wallets generate multiple payment keys per wallet account, this could lead us proposal forum to misidentifying the users

It would be a better idea to use stake keys as a proxy for identity as multi-stake key wallets are not prevalent within the ecosystem
furthermore at wallet connection time govtool forces users with multi-stake key wallet to choose the stake key, meaning each connection to govtool is with one stake key at a time

Steps to reproduce

Connect to proposal discussion forum

Actual behavior

Signing with payment key

image

Expected behavior

Signing with stake key

@Ryun1 Ryun1 added the 🐛 Bug Something isn't working label Aug 23, 2024
@Ryun1 Ryun1 changed the title 🐛 Use 🐛 Use stake key for proposal forum identity Aug 23, 2024
@vpaunovic
Copy link

Its done. Ready to go to QA after it is implemented on GovTool.

@bosko-m @Ryun1 @ValMBO

@Ryun1
Copy link
Member Author

Ryun1 commented Aug 23, 2024

LGTM

also
to make things easier, we should move to have the PDF UI and PDF BE in one repo, in the near future

@vpaunovic
Copy link

@Ryun1 This also should be deployed and working.

CC: @bosko-m @ValMBO

@bosko-m bosko-m closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 📜 Proposal Pillar
Projects
Status: Done
Development

No branches or pull requests

3 participants