Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Incorrect deposit amount reported via error message at proposal -> governance action time #1729

Closed
kickloop opened this issue Aug 13, 2024 · 7 comments
Labels
🐛 Bug Something isn't working usersnap-bug

Comments

@kickloop
Copy link
Collaborator

Sender: None
Taken at: https://sanchogov.tools/proposal_discussion/16
Fields:

  • Add a comment: I have nearly tAda 100k in my SanchoNet Demos wallet. When I attempt to submit an info governance action I am told that I need at least 50k tAda to submit the action, and so the action cannot be submitted.

Browser: Chrome 127 (Windows 10)
Screen size: 1368x912
View screen recording
Open #104 in Usersnap

Powered by Usersnap.

@Ryun1
Copy link
Member

Ryun1 commented Aug 13, 2024

error message reporting incorrect value for proposal deposit size (is currently 100K on Sancho)
image

@Ryun1
Copy link
Member

Ryun1 commented Aug 13, 2024

Not sure why this goes wrong, perhaps it is pulling incorrect params from getItemFromLocalStorage(PROTOCOL_PARAMS_KEY); as GA deposit was 50K on Sancho a few months ago 🤔

https://github.com/IntersectMBO/govtool/blob/develop/govtool/frontend/src/hooks/forms/useCreateGovernanceActionForm.ts#L243

@Ryun1 Ryun1 added the 🐛 Bug Something isn't working label Aug 13, 2024
@Ryun1 Ryun1 changed the title [USERSNAP] I have nearly tAda 100k in my SanchoNet Demos wallet. When I attempt to submit an info governance action I am told that I need at least 50k tAda to submit the action, and so the action cannot be submitted. 🐛 Incorrect deposit amount reported via error message at proposal -> governance action time Aug 13, 2024
@MSzalowski
Copy link
Contributor

I'm not sure if that error modal is on the wrapper level. @teske00 could you confirm if that one isn't on the proposal pillar side?

@MSzalowski
Copy link
Contributor

And @Ryun1 gov action deposit on Sancho Beta is 100k - that can be checked on the:
Dev Console > Application > Local storage > protocol_params (pic rel)

Zrzut ekranu z 2024-08-13 14-36-53

@teske00
Copy link

teske00 commented Aug 13, 2024

@MSzalowski @Ryun1 Yes, it is an error on the modal in the PDF. We didn't know this state existed in localstorage, we will implement a dynamic value change in the modal depending on the state in localstorage. By the end of the day we will have a new version of the PDF with it

@teske00
Copy link

teske00 commented Aug 13, 2024

@MSzalowski We have updated the PDF package to version 0.3.5, it is ready for import

@Ryun1
Copy link
Member

Ryun1 commented Sep 12, 2024

This is fixed

@Ryun1 Ryun1 closed this as completed Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working usersnap-bug
Projects
Status: Done
Development

No branches or pull requests

4 participants