Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upload button for transaction' #99

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Add upload button for transaction' #99

merged 1 commit into from
Feb 21, 2025

Conversation

elenabardho
Copy link
Collaborator

List of changes

  • Add upload button to retrieve tx hex from files

@elenabardho elenabardho linked an issue Feb 19, 2025 that may be closed by this pull request
V1.3 - Add file import for unsigned transaction #96
Open
@elenabardho elenabardho marked this pull request as ready for review February 19, 2025 12:48
@elenabardho elenabardho requested a review from Ryun1 as a code owner February 19, 2025 12:48
@Ryun1
Copy link
Member

Ryun1 commented Feb 19, 2025

What validation does this do?

  • check for .unsigned and .json file extension
  • check that the file contains JSON data and a cborhex field

@Ryun1
Copy link
Member

Ryun1 commented Feb 21, 2025

also check against people uploading massive or dangerous files

@elenabardho elenabardho merged commit 9814386 into v1.3 Feb 21, 2025
1 check passed
@elenabardho elenabardho deleted the feat/add-import-tx-file branch February 21, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryun1 Ryun1 Ryun1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V1.3 - Add file import for unsigned transaction
2 participants
@elenabardho @Ryun1