From 50e89f3f3615aed61f83ea8deff93eddaa06b782 Mon Sep 17 00:00:00 2001 From: MGukic Date: Tue, 10 Dec 2024 18:53:03 +0100 Subject: [PATCH 1/4] feat: Changed No Revisions text --- frontend/messages/de.json | 4 ++-- frontend/messages/en.json | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/frontend/messages/de.json b/frontend/messages/de.json index b5f6d3d4..01c5ff7e 100644 --- a/frontend/messages/de.json +++ b/frontend/messages/de.json @@ -281,7 +281,7 @@ }, "constitutionMetadata": { "title": "No revisions available", - "description": "There are currently no revisions available. Please check back later for updates" + "description": "There is only 1 version available. Once there are multiple versions of the constitution, you will be able to compare two versions" }, "governanceAction": { "title": "No governance actions available", @@ -289,7 +289,7 @@ }, "versionHistory": { "title": "No revisions available", - "description": "There are currently no revisions available. Please check back later for updates" + "description": "There is only 1 version available. Once there are multiple versions of the constitution, you will be able to compare two versions" } }, "Snackbar": { diff --git a/frontend/messages/en.json b/frontend/messages/en.json index f2911994..5f6db112 100644 --- a/frontend/messages/en.json +++ b/frontend/messages/en.json @@ -281,7 +281,7 @@ }, "constitutionMetadata": { "title": "No revisions available", - "description": "There are currently no revisions available. Please check back later for updates" + "description": "There is only 1 version available. Once there are multiple versions of the constitution, you will be able to compare two versions" }, "governanceAction": { "title": "No governance actions available", @@ -289,7 +289,7 @@ }, "versionHistory": { "title": "No revisions available", - "description": "There are currently no revisions available. Please check back later for updates" + "description": "There is only 1 version available. Once there are multiple versions of the constitution, you will be able to compare two versions" } }, "Snackbar": { From 027cb498e0b70d64e512075d9cfd53acf5d18acd Mon Sep 17 00:00:00 2001 From: MGukic Date: Tue, 10 Dec 2024 19:56:40 +0100 Subject: [PATCH 2/4] fix: Fixed footer position --- frontend/src/components/organisms/NotFound.tsx | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/frontend/src/components/organisms/NotFound.tsx b/frontend/src/components/organisms/NotFound.tsx index 05739cb7..5b13fafe 100644 --- a/frontend/src/components/organisms/NotFound.tsx +++ b/frontend/src/components/organisms/NotFound.tsx @@ -8,7 +8,7 @@ import { customPalette } from "@/constants"; export function NotFound({ title, description, - height = "70vh", + height = "82vh", sx, }: { title: string; @@ -23,7 +23,7 @@ export function NotFound({ display="flex" justifyContent="center" alignItems="center" - sx={{ height }} + sx={{ height, backgroundColor: customPalette.neutralWhite }} > - + {t(title)} - + {t(description)} From c12d79ae06164fe75e1c8df81d6e8e0c585a64cc Mon Sep 17 00:00:00 2001 From: MGukic Date: Thu, 12 Dec 2024 18:09:46 +0100 Subject: [PATCH 3/4] feat: Displayed full description if user hover MembersCard --- .../organisms/MembersCard/MembersCard.tsx | 72 +++++++++++++------ 1 file changed, 49 insertions(+), 23 deletions(-) diff --git a/frontend/src/components/organisms/MembersCard/MembersCard.tsx b/frontend/src/components/organisms/MembersCard/MembersCard.tsx index f3dadaab..5b6dad12 100644 --- a/frontend/src/components/organisms/MembersCard/MembersCard.tsx +++ b/frontend/src/components/organisms/MembersCard/MembersCard.tsx @@ -12,13 +12,14 @@ export const MembersCard = ({ name, description, profile_photo_url, - created_at + created_at, }: Pick< UserListItem, "name" | "id" | "description" | "created_at" | "profile_photo_url" >) => { const t = useTranslations("Members"); + const shouldClampText = description?.length > 234; return ( - - - - - - {name} + + + + + + + {name} + - - {description} - - + + {description} + - {/** + {/** * temporarily hidden * TODO: uncomment and handle button click *