Skip to content

Empty list of stakeholderid in byron EBB is forbidden by CDDL but generated by codecs #4928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jasagredo opened this issue Mar 17, 2025 · 1 comment · Fixed by #5057
Closed

Empty list of stakeholderid in byron EBB is forbidden by CDDL but generated by codecs #4928

jasagredo opened this issue Mar 17, 2025 · 1 comment · Fixed by #5057
Labels
bug Something isn't working cddl Issues related to cddl specification serialization Anything that affects serialization of ledger types

Comments

@jasagredo
Copy link
Contributor

jasagredo commented Mar 17, 2025 •
edited
Loading

The byron cddl spec defines an ebb block as:

ebblock = [ "header" : ebbhead
          , "body" : [+ stakeholderid]
          , extra : [attributes]
          ]

whereas the encoding for a byron ebb body is defined as:

-- | Every boundary body has the same encoding: empty.
encCBORABoundaryBody :: ABoundaryBody a -> Encoding
encCBORABoundaryBody _ =
  (encodeListLenIndef <> encodeBreak)
    <> ( encodeListLen 1
          <> encCBOR (mempty :: Map Word8 LByteString)
       )

So the generated body has an empty list, while the CDDL specifies a non-empty list.
@jasagredo jasagredo changed the title Empty list in byron EBB is forbidden by CDDL Empty list of stakeholderid in byron EBB is forbidden by CDDL but generated by codecs Mar 17, 2025
@lehins lehins added serialization Anything that affects serialization of ledger types cddl Issues related to cddl specification bug Something isn't working labels Mar 18, 2025
@jasagredo jasagredo mentioned this issue Mar 24, 2025
Closed
48 tasks
@jasagredo
Copy link
Contributor Author

Fixed by #5050

This was linked to pull requests May 16, 2025
Some fixes to CDDLs based on the Consensus golden examples of blocks #5050
Closed
Change Byron EBB stakeholderid to zero-or-more #5057
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working cddl Issues related to cddl specification serialization Anything that affects serialization of ledger types
Projects
None yet
Milestone
No milestone
2 participants
@lehins @jasagredo