Improve TxSeq decoders
#4904
Open
Improve TxSeq decoders
#4904
+87
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and reuse it in all `TxSeq` decoders
teodanciu
force-pushed
the
td/improve-txseq-decoders
branch
from
68bc780 to
e5934d3
Compare
lehins
approved these changes
Feb 21, 2025
| @@ -242,6 +226,21 @@ txSeqDecoder lax = do | |||
| Seq.zipWith3 segWitAnnTx bodies wits metadata | |||
| pure $ TxSeq' <$> txns <*> bodiesAnn <*> witsAnn <*> metadataAnn | |||
|
|
|||
| auxDataSeqDecoder :: | |||
| Int -> IntMap (m (TxAuxData era)) -> Bool -> Decoder s (Seq (Maybe (m (TxAuxData era)))) | |||
There was a problem hiding this comment.
This will allow you to avoid using runIdentity
Suggested change
| Int -> IntMap (m (TxAuxData era)) -> Bool -> Decoder s (Seq (Maybe (m (TxAuxData era)))) | |
| Int -> IntMap a -> Bool -> Decoder s (Seq (Maybe a)) |
Comment on lines
+244
to
+245
| fmap (fmap runIdentity) | ||
| <$> auxDataSeqDecoder bodiesLength (fmap pure auxDataMap) False |
There was a problem hiding this comment.
There is no need to complicate the normal decoder
Suggested change
| fmap (fmap runIdentity) | |
| <$> auxDataSeqDecoder bodiesLength (fmap pure auxDataMap) False | |
| auxDataSeqDecoder bodiesLength auxDataMap False |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the decoders of the
TxAuxDatawithinTxSeqto deserialize asIntMapinstead ofMap IntCloses #4900
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changesNew section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessaryIf you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
scripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlupdated (usescripts/gen-hie.sh)