Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a flaky test #4891

Closed
wants to merge 1 commit into from
Closed

Fixed a flaky test #4891

wants to merge 1 commit into from

Conversation

Soupstraw
Copy link
Contributor

Description

This test sometimes failed if the ppCoinsPerUTxOByte parameter happened to be set to a bad value. This PR sets the parameter to a fixed value to get rid of this flakiness.

closes #4885

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw requested a review from a team as a code owner February 14, 2025 15:16
@lehins
Copy link
Collaborator

lehins commented Feb 14, 2025

Already fixed in #4887

@lehins lehins closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression Test failure on CI: InsufficientCollateral
2 participants