Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the soundness checks in Test.Cardano.Ledger.STS to cardano-ledger-conformance #4884

Open
Soupstraw opened this issue Feb 11, 2025 · 1 comment

Comments

@Soupstraw
Copy link
Contributor

Soupstraw commented Feb 11, 2025

There are some soundness checks for the constrained specs in Test.Cardano.Ledger.STS, but I have moved some of these specs into cardano-ledger-conformance and commented out the corresponding soundness checks. We should move these soundness tests into cardano-ledger-conformance as well and re-enable them.

It would make more sense to use the specs from the ExecSpecRule instance of each era.

@Soupstraw
Copy link
Contributor Author

Soupstraw commented Feb 11, 2025

Actually now that I think about it, we don't really need the tests in that module, since they just generate the inputs to an STS rule and then try to run the STS rule with these inputs. We essentially do that already with confomance tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant