Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of Pretty interface in favor of ToExpr #4873

Open
lehins opened this issue Feb 4, 2025 · 0 comments
Open

Get rid of Pretty interface in favor of ToExpr #4873

lehins opened this issue Feb 4, 2025 · 0 comments
Assignees
@Lucsanszky
Labels
💳 technical-debt Issues related to technical debt we introduced

Comments

@lehins
Copy link
Collaborator

lehins commented Feb 4, 2025

Defining custom pretty instances is time consuming and frustrating, moreover it has no value as generically derived ToExpr instances provide us with superior functionality: they are derivable and they provide diffing out of the box.
Most importantly, however, they are unreadable and error prone, due to requiring manual definition.

Test.Cardano.Ledger.Generic.PrettyCore module and related functionality needs to go!
@lehins lehins added the 💳 technical-debt Issues related to technical debt we introduced label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lucsanszky Lucsanszky

Labels
💳 technical-debt Issues related to technical debt we introduced
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lehins @Lucsanszky