Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt removing conditional translation of certificates #4863

Open
lehins opened this issue Jan 31, 2025 · 0 comments · May be fixed by #4881
Open

Attempt removing conditional translation of certificates #4863

lehins opened this issue Jan 31, 2025 · 0 comments · May be fixed by #4881
Assignees
Labels
💳 technical-debt Issues related to technical debt we introduced

Comments

@lehins
Copy link
Collaborator

lehins commented Jan 31, 2025

We should try removing this conditional translation and see if the chains are replayed successfully up to the hard fork into protocol version 10.0

RegDepositTxCert stakeCred deposit ->
let transDeposit
| HF.bootstrapPhase pv = Nothing
| otherwise = Just (transCoinToLovelace deposit)
in PV3.TxCertRegStaking (transCred stakeCred) transDeposit
UnRegDepositTxCert stakeCred refund ->
let transRefund
| HF.bootstrapPhase pv = Nothing
| otherwise = Just (transCoinToLovelace refund)
in PV3.TxCertUnRegStaking (transCred stakeCred) transRefund

In case that this has not been exercised on preview, preprod and mainnet we can safely remove it and pretend like it never happen. Otherwise make a note int he code on why it can not be removed.

@lehins lehins added the 💳 technical-debt Issues related to technical debt we introduced label Jan 31, 2025
@Soupstraw Soupstraw self-assigned this Feb 7, 2025
@Soupstraw Soupstraw linked a pull request Feb 10, 2025 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💳 technical-debt Issues related to technical debt we introduced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants