Billing migration - Html

[michalcharvat]

Billing migration is pain in the neck because Html custom field does not support import the old value if there is detected XSS in the old value.

if(!empty($value) && StringUtil::detectXSS($value)) {
    $model->setValidationError("customFields." . $field->databaseName, ErrorCode::INVALID_INPUT, "You're not allowed to put scripts in customFields." . $field->databaseName);				
    return false;
}

it would be nice to allow import these old values with some kind of exception. I agree it is a security issue but with thousands of documents with html in it you are not able to migrate old billing module to finance.

Other issues I have found during migration:

• products without default language will stop the migration process - solved by

insert into bs_product_languages (product_id, language_id, name) select id, 1, 'Unknown' from bs_products where id NOT IN (select product_id from bs_product_languages where language_id = 1);

• missing custom fields - for example Notes - solved by recreating them
• billing does not count with the credit notes but if you have credit note category you have to migrate it manually