From f2662303b8b473beb819b956b006f19fed9018c0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julien=20=C3=89LIE?= <Julien-Elie@users.noreply.github.com>
Date: Sat, 8 Jul 2023 17:57:53 +0200
Subject: [PATCH] Fix inclusion of <sys/select.h>

It was sometimes missing, and sometimes useless.
---
 innd/innd.c      | 5 +++++
 lib/nntp.c       | 5 +++++
 nnrpd/auth-ext.c | 5 +++++
 nnrpd/misc.c     | 5 -----
 nnrpd/nnrpd.c    | 5 +++++
 nnrpd/perm.c     | 5 -----
 6 files changed, 20 insertions(+), 10 deletions(-)

diff --git a/innd/innd.c b/innd/innd.c
index 9889225d2..7068a34cd 100644
--- a/innd/innd.c
+++ b/innd/innd.c
@@ -4,6 +4,11 @@
 
 #include "portable/system.h"
 
+/* Needed on AIX 4.1 to get fd_set and friends. */
+#ifdef HAVE_SYS_SELECT_H
+#    include <sys/select.h>
+#endif
+
 #include "inn/innconf.h"
 #include "inn/messages.h"
 #include "inn/newsuser.h"
diff --git a/lib/nntp.c b/lib/nntp.c
index 1281988bf..c62d41691 100644
--- a/lib/nntp.c
+++ b/lib/nntp.c
@@ -16,6 +16,11 @@
 #endif
 #include <time.h>
 
+/* Needed on AIX 4.1 to get fd_set and friends. */
+#if HAVE_SYS_SELECT_H
+#    include <sys/select.h>
+#endif
+
 #include "inn/buffer.h"
 #include "inn/innconf.h"
 #include "inn/libinn.h"
diff --git a/nnrpd/auth-ext.c b/nnrpd/auth-ext.c
index 732aa1d36..e8480b882 100644
--- a/nnrpd/auth-ext.c
+++ b/nnrpd/auth-ext.c
@@ -12,6 +12,11 @@
 #include <signal.h>
 #include <sys/wait.h>
 
+/* Needed on AIX 4.1 to get fd_set and friends. */
+#if HAVE_SYS_SELECT_H
+#    include <sys/select.h>
+#endif
+
 #include "inn/buffer.h"
 #include "inn/messages.h"
 #include "inn/vector.h"
diff --git a/nnrpd/misc.c b/nnrpd/misc.c
index 438dba292..ba9bee825 100644
--- a/nnrpd/misc.c
+++ b/nnrpd/misc.c
@@ -4,11 +4,6 @@
 
 #include "portable/system.h"
 
-/* Needed on AIX 4.1 to get fd_set and friends. */
-#ifdef HAVE_SYS_SELECT_H
-#    include <sys/select.h>
-#endif
-
 #include "inn/innconf.h"
 #include "nnrpd.h"
 #include "tls.h"
diff --git a/nnrpd/nnrpd.c b/nnrpd/nnrpd.c
index c65f571f5..9a1325ba6 100644
--- a/nnrpd/nnrpd.c
+++ b/nnrpd/nnrpd.c
@@ -20,6 +20,11 @@
 #endif
 #include <sys/wait.h>
 
+/* Needed on AIX 4.1 to get fd_set and friends. */
+#if HAVE_SYS_SELECT_H
+#    include <sys/select.h>
+#endif
+
 #include "inn/innconf.h"
 #include "inn/libinn.h"
 #include "inn/messages.h"
diff --git a/nnrpd/perm.c b/nnrpd/perm.c
index aa4087987..63e52aa14 100644
--- a/nnrpd/perm.c
+++ b/nnrpd/perm.c
@@ -28,11 +28,6 @@ enum {
 #include "nnrpd.h"
 #include "tls.h"
 
-/* Needed on AIX 4.1 to get fd_set and friends. */
-#ifdef HAVE_SYS_SELECT_H
-#    include <sys/select.h>
-#endif
-
 /* Data types. */
 typedef struct _CONFCHAIN {
     CONFFILE *f;