Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run example UI tests on build/release #5

Open
PandaMagnus opened this issue Jan 6, 2023 · 3 comments
Open

Don't run example UI tests on build/release #5

PandaMagnus opened this issue Jan 6, 2023 · 3 comments

Comments

@PandaMagnus
Copy link
Contributor

No description provided.

@BenjaminMichaelis
Copy link
Member

UI Tests are now passing on windows 🎉

On mac, we are waiting to hear from browser-actions/setup-chrome#329 to see if we can get that going and if it doesn't get resolved, we'll either have to not run the UI tests on the runner or find another way to update chromium... Maybe only run the UI tests on windows and the rest of the tests on both Windows and Mac??

@PandaMagnus
Copy link
Contributor Author

@BenjaminMichaelis I went ahead and just excluded the test runs for now since they're examples. It would probably make most sense to have them be a separate job so that it doesn't block merging or deployment, but will let us know if things drift out of date again.

@BenjaminMichaelis
Copy link
Member

Yeah we can build another step to do that, should be pretty trivial

@PandaMagnus PandaMagnus mentioned this issue Apr 2, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BenjaminMichaelis @PandaMagnus