Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit #266

Open
cwlacewe opened this issue Feb 20, 2025 · 0 comments · May be fixed by #267
Open

Add pre-commit #266

cwlacewe opened this issue Feb 20, 2025 · 0 comments · May be fixed by #267
Assignees
Labels
Enhancement New features or upgrades for functionality, performance, etc

Comments

@cwlacewe
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, if a contributor does not format the code properly, sys_vdms makes a commit to the PR branch with format changes. This causes it to rerun the CI workflows with the format changes. To avoid this, we should have an automatic process.

Describe the solution you'd like
A solution is to enable the repo with pre-commit hooks. By doing so, the checks are run automatically prior to committing new code or the user can run pre-commit run --all-files (after running pip install pre-commit).

@cwlacewe cwlacewe added the Enhancement New features or upgrades for functionality, performance, etc label Feb 20, 2025
@cwlacewe cwlacewe self-assigned this Feb 20, 2025
@cwlacewe cwlacewe linked a pull request Feb 20, 2025 that will close this issue
3 tasks
@cwlacewe cwlacewe linked a pull request Feb 20, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New features or upgrades for functionality, performance, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant