Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary Flush Calls for Find/Classify Descriptor Command #183

Open
ifadams opened this issue Jul 23, 2024 · 0 comments
Open

Unnecessary Flush Calls for Find/Classify Descriptor Command #183

ifadams opened this issue Jul 23, 2024 · 0 comments
Labels
Bug Indicates unexpected or undesired behaviors Priority: Backlog Tasks that are not pressing, but to be tracked and revisited

Comments

@ifadams
Copy link
Contributor

ifadams commented Jul 23, 2024

Describe the bug
Function calls to ClassifyDescriptor() and FindDescriptor() in descriptorcommand.cc copy the descriptors to storage un-necessarily

To Reproduce

  1. ClassifyDescriptor() function(https://github.com/intel-innersource/libraries.databases.visual.vdms/blob/7eceb2f416976e806983e29a170e4653edab6413/src/DescriptorsCommand.cc#L490) calls in flush in Line 528
  2. Flush Function calls descriptormanger.cc flush() (https://github.com/intel-innersource/libraries.databases.visual.vdms/blob/7eceb2f416976e806983e29a170e4653edab6413/src/DescriptorsManager.cc#L55) which calls vcl->store()
  3. The store() function in VCL (https://github.com/intel-innersource/libraries.databases.visual.vdms/blob/7eceb2f416976e806983e29a170e4653edab6413/src/vcl/DescriptorSet.cc#L176) stores a local copy of the files with write_set_info() () (not needed if AWS only functionality is needed) and additionally calls AWS for storage

Same behavior happens in the FindDescriptor() function (https://github.com/intel-innersource/libraries.databases.visual.vdms/blob/7eceb2f416976e806983e29a170e4653edab6413/src/DescriptorsCommand.cc#L113)

Expected behavior
Both Classify and Find are read-only operations and flushing to storage should not happen

@ifadams ifadams added Bug Indicates unexpected or undesired behaviors Priority: Backlog Tasks that are not pressing, but to be tracked and revisited labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Indicates unexpected or undesired behaviors Priority: Backlog Tasks that are not pressing, but to be tracked and revisited
Projects
None yet
Development

No branches or pull requests

1 participant