From f99d8614b806e8e0d85b058346d66651090b31f6 Mon Sep 17 00:00:00 2001 From: Tim Oliver Date: Sun, 19 Nov 2023 17:57:35 -0800 Subject: [PATCH] Fix UI test timeout when running on GitHub Actions Summary: The previous CI changes landed this morning, however there was still some test flakiness. From the logs, it looked like an Accessibility dialog was being shown during the UI tests, and this was causing them to time out. On closer inspection of the logs , I discovered the 'pre-heat' step in the UI tests pipeline was incorrectly choosing the wrong iPhone 14 Pro simulator, since GitHub Actions on macOS 13 offers both iOS 16.4 and iOS 17.0 devices (Even if Xcode 14 was explicitly declared). In order to ensure the same iOS Simulator is used throughout the UI tests, this diff explicitly declares the iOS version it expects to be working with. Differential Revision: D51293930 fbshipit-source-id: ddeee7a6aa8f826541bc1aeb56ed6a8445534694 --- .github/workflows/CI.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index e8c885562..ad874edef 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -204,7 +204,7 @@ jobs: EXAMPLE_SCHEME: IGListKitExamples strategy: matrix: - iosDestination: ["platform=iOS Simulator,name=iPhone 14 Pro"] + iosDestination: ["platform=iOS Simulator,name=iPhone 14 Pro,OS=16.4"] tvOSDestination: ["platform=tvOS Simulator,name=Apple TV 4K (3rd generation)"] macOSDestination: ["platform=macOS"] macCatalystDestination: ["platform=macOS,variant=Mac Catalyst"] @@ -227,7 +227,7 @@ jobs: uses: futureware-tech/simulator-action@v2 with: model: 'iPhone 14 Pro' - os_version: '>=16.0' + os_version: '=16.4' - name: Build iOS Example - ${{ matrix.iosDestination }} run: | @@ -279,4 +279,4 @@ jobs: - name: Run Danger run: bundle exec danger --verbose - \ No newline at end of file +