forked from blowekamp/itkExternalTemplate
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Convert README from ReStructured Text to MarkDown #168
Open
thewtex
wants to merge
3
commits into
InsightSoftwareConsortium:main
Choose a base branch
from
thewtex:markdown-readme
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzenanz
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on a glance.
The commit message contradicts the actual change: the commit is changing |
More common, widely supported, and easier to write.
thewtex
force-pushed
the
markdown-readme
branch
from
December 1, 2024 18:54
d25915e
to
eec63ce
Compare
thewtex
changed the title
ENH: Convert README from MarkDown to ReStructured Text
ENH: Convert README from ReStructured Text to MarkDown
Dec 1, 2024
@jhlegarreta good catch, addressed! |
thewtex
force-pushed
the
markdown-readme
branch
from
December 1, 2024 18:56
eec63ce
to
2c4e975
Compare
To address libtiff errors and other warnings. Update ITK Git tag, ITKPythonPackage Git tag. Use macos-13 over macos-12 for CXX builds. Add macos-14 for CXX builds. Update VisualStudio initialization script call. Do not build Python 3.8 packages, which will soon be dropped.
thewtex
force-pushed
the
markdown-readme
branch
from
December 1, 2024 20:00
2c4e975
to
28eaa85
Compare
jhlegarreta
approved these changes
Dec 1, 2024
Use python3-minor-version. Set ITKPYTHONPACKAGE_ORG. Pass the Python version to the download script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More common, widely supported, and easier to write. Closes #84.