Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove double semicolons #5123

Open
dzenanz opened this issue Jan 6, 2025 · 2 comments
Open

Remove double semicolons #5123

dzenanz opened this issue Jan 6, 2025 · 2 comments
Labels
Good first issue A good issue for community members new to contributing type:Style Style changes: no logic impact (indentation, comments, naming)

Comments

@dzenanz
Copy link
Member

dzenanz commented Jan 6, 2025

See discussion here for context:
#5108 (comment)

Double semicolons (;;) should only be removed from C++, not from bash etc.
@dzenanz dzenanz added Good first issue A good issue for community members new to contributing type:Style Style changes: no logic impact (indentation, comments, naming) labels Jan 6, 2025
@seanm
Copy link
Contributor

seanm commented Jan 7, 2025

BTW clang can fix these automatically with -Xclang -fix-only-warnings and -Wextra-semi

@dzenanz
Copy link
Member Author

dzenanz commented Jan 7, 2025

Could you give that a try, Sean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue A good issue for community members new to contributing type:Style Style changes: no logic impact (indentation, comments, naming)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanm @dzenanz