Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise cmake_minimum_required in remote modules #4761

Open
jhlegarreta opened this issue Jun 27, 2024 · 1 comment
Open

Raise cmake_minimum_required in remote modules #4761

jhlegarreta opened this issue Jun 27, 2024 · 1 comment
Labels
type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Comments

@jhlegarreta
Copy link
Member

Description

The dashboard is displaying configure warnings related to the cmake_minimum_required version value in remote modules, e.g.
https://open.cdash.org/builds/9713834/configure
https://open.cdash.org/builds/9713631/configure
https://open.cdash.org/builds/9716262/configure

It needs to be updated to 3.16.3 to be up-to-date with ITK, i.e.

cmake_minimum_required(VERSION ${ITK_OLDEST_VALIDATED_POLICIES_VERSION}...${ITK_NEWEST_VALIDATED_POLICIES_VERSION}

if(MSVC AND ${CMAKE_MINIMUM_REQUIRED_VERSION} LESS 3.16.3)

Impact analysis

Remotes are being packaged with configure warnings.

Expected behavior

No configure warnings are raised.

Actual behavior

Configure warnings are present.

Versions

All HEAD versions of remotes.

Environment

N/A.

Additional Information

Identified while inspecting the dashboard from builds triggered by the changes in issue #4748.

Unfortunately, the GitHub action builds are not reporting these warnings as failures, and thus they may go unnoticed.

@jhlegarreta jhlegarreta added the type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots label Jun 27, 2024
@jhlegarreta
Copy link
Member Author

This script should eventually help in applying the change across all repositories with reduced effort:
thewtex@9e9d513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Development

No branches or pull requests

1 participant