Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend for tournament administration #173

Merged
merged 108 commits into from
Mar 6, 2025
Merged

Frontend for tournament administration #173

merged 108 commits into from
Mar 6, 2025
+3,708 −546

Conversation

istar410
Copy link
Contributor

@istar410 istar410 commented Jan 24, 2025 •
edited
Loading

Description

The objective is to provide a better user interface for the admin tournament team to manage tournaments.

Checklist

  • I have tested the changes locally and they work as expected.
  • I have tested the responsiveness of the changes and they work as expected.
  • I have assigned the pull request to the appropriate reviewer(s).
  • I have added labels to the pull request, if necessary.

Related Issues

Will fix #127

To do

  • Teams :
    • List of teams and their seeding
  • Groups :
    • Groups creation
    • List of groups with score summaries
    • Tiebreak scores inside groups
    • Edit Group :
      • name
      • teams
      • teams' seeding
      • teams' tiebreak score
    • Groups' matchs creation
    • Detail list of groups' matchs
    • Launch groups' matchs by round
    • Launch a selection of groups' matchs
    • Edit group match :
      • BO type
      • teams
  • Swiss Round :
    • Swiss round creation with matchs
    • Launch swiss round's matchs by round
    • Launch selected swiss round's matchs
    • Generate subsequent round matchs from previous results
    • Edit matchs :
      • BO type
      • teams
  • Brackets :
    • Brackets creation
      • by hand
      • automaticaly from groups or swiss rounds results
    • Launch matchs by round
    • Launch selected matchs
    • Edit matchs :
      • BO type
      • teams

Sorry, something went wrong.

@istar410 istar410 mentioned this pull request Jan 30, 2025
Merged
5 tasks
@istar410 istar410 requested review from KwikKill and floflo0 February 14, 2025 23:11
KwikKill
KwikKill reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@KwikKill KwikKill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on a really good way. Not many comments on either the code or the operation, very good work.

@istar410 istar410 marked this pull request as ready for review February 20, 2025 21:01
@istar410 istar410 requested a review from KwikKill February 20, 2025 21:02
KwikKill
KwikKill approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@KwikKill KwikKill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

KwikKill
KwikKill reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@KwikKill KwikKill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good most of the time but for the groups it look strange (stretched)
image

istar410 and others added 17 commits March 6, 2025 11:07
@istar410 @floflo0
first draft for tournament admin views

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c6a9ec2
@istar410 @floflo0
improve admin teams seeding form and add validation
a8a4776
@istar410 @floflo0
improve breakpoints and tournament info dropdown
e33488e
@istar410 @floflo0
add admin seating path
7546845
@istar410 @floflo0
add save icon
d1446d1
@istar410 @floflo0
fix group teams type to a list of numbers
556355b
@istar410 @floflo0
switch from Error to Notification
2f0dcad
@istar410 @floflo0
finish team seeding update implementation + minor UI fixes
5f44f96
@istar410 @floflo0
use tournament store to access validated teams in GroupTable
7e7a9bd
@istar410 @floflo0
add tiebreak scores
67de260
@istar410 @floflo0
create AdminGroupTable
60caaeb
@istar410 @floflo0
can edit group data
a94a47d
@istar410 @floflo0
update button ui for AdminGroups page
da5b3aa
@istar410 @floflo0
create or delete all groups
97a5a93
@istar410 @floflo0
create or delete all groups matchs
71a48c3
@istar410 @floflo0
launch a round of groups matchs
a3fd38b
@floflo0
add padding around tournament name on TournamentDetail page
9b9ad5d
KwikKill and others added 27 commits March 6, 2025 11:10
@KwikKill @floflo0
Improve AdminMatch UI
cba8933
@istar410 @floflo0
UI improvements for AdminMatch
31370de
@istar410 @floflo0
can specify best of type when creating a bracket
1cedf15
@istar410 @floflo0
fix error when accessing AdminGroupMatchs whitout any groups
ca1ce76
@istar410 @floflo0
rework swiss rounds and brackets public interface
f285bbf
@istar410 @floflo0
fix overflows in AdminMatch
22f3897
@istar410 @floflo0
use tournament store to access validated teams
0290158
@istar410 @floflo0
fix uncentered match status in AdminMatch
ed65de2
@istar410 @floflo0
switch from table to div layout for AdminMatch
911c5c4
@istar410 @floflo0
change background, switch from border to ring and some spacing adjust…
bb2074b 
…ments
@istar410 @floflo0
improve final winner display
f9448b9
@istar410 @floflo0
update AdminMatch ui
dd8fff5
@istar410 @floflo0
restrict access to tournament admin pages
2612aec
@istar410 @floflo0
improve admin groups' matchs table
bfac939
@istar410 @floflo0
translate hover text to french
534bef2
@istar410 @floflo0
add isAdmin computed to user
5560fa4
@istar410 @floflo0
improve modal title for reporting scores
e163a78
@istar410 @floflo0
minor fixes in AdminMatch
8c54ba4
@istar410 @floflo0
rework group table and improve admin edition capabilities
263bc5d
@istar410 @floflo0
remove unecessary props
9c33ef3
@istar410 @floflo0
rename AdminMatch to MatchCard and use it for all matchs
2e48fd7
@istar410 @floflo0
remove unused KnockoutMatchCard
dc60893
@istar410 @floflo0
fix matchs layout in admin groups' matchs table
7b53c4a
@KwikKill @floflo0
Fix modal z index
c11a831
@istar410 @floflo0
make tournament admin button only visible for members of the tourname…
418ce35 
…nt team
@istar410 @floflo0
Improve validation error's messages localisation (#179)
c96a630 
* rework errors localisation

* switch to localized error messages in tournament admin pages and improve data validations

* some ui improvements of validation messages

* fix validation causing errors

* fix crash if no ongoing match

* fix wrong max_score computation for ranking and missing .value

* fix type for ongoing match teams property

* switch to localized validators for GroupTable

* improve error message display for GroupTable

* add required validator

* fix type error
@floflo0
Remove TournamentAdminInfo
Loading
Loading status checks…
2e184f0
@floflo0 floflo0 force-pushed the tournament-admin branch from 74c96e6 to 2e184f0 Compare March 6, 2025 10:11
@floflo0 floflo0 merged commit 43a1884 into dev Mar 6, 2025
3 checks passed
@floflo0 floflo0 deleted the tournament-admin branch March 6, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floflo0 floflo0

@KwikKill KwikKill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tournament front
3 participants
@istar410 @KwikKill @floflo0