Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the data structure for animations correct? #40

Closed
helloar14 opened this issue Apr 11, 2023 · 2 comments
Closed

Is the data structure for animations correct? #40

helloar14 opened this issue Apr 11, 2023 · 2 comments
Milestone

Comments

@helloar14
Copy link

helloar14 commented Apr 11, 2023

In the current data structure for animations:

  • Animations is an object;
  • Each animation is a property with the property name same as Animation name.

If we refer to parameters, shouldn't this be:

  • Animations is an Array of Object;
  • Each object has properties which is timestep, animationWeight, lanes, etc... AND animationName.

This way parameters, animations and bindings from Session will have a somewhat consistent structure.

@LunaTheFoxgirl
Copy link
Member

Animation being indexed by name is more an optimization thing, but yeah, we should probably chose to write one or the other out to file instead of both...

@LunaTheFoxgirl
Copy link
Member

LunaTheFoxgirl commented Apr 25, 2023

After looking through it, the data structure is as intended. The reason being is that Animations use their name as a key, as such the key should be unique. Parameters on the other hand is indexed by their UUID, as such multiple parameters can share a name.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Inochi2D Tasklist Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants