Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21] Locked slots will accept the wrong items from automation inserts #1473

Closed
MuteTiefling opened this issue Sep 24, 2024 · 0 comments
Closed

Comments

@MuteTiefling
Copy link

DO NOT REPORT AN ISSUE IF YOU HAVEN'T TESTED THE ISSUE WITH THE LATEST VERSION IN CURSEFORGE

This appears to be an issue in all machines. But it's most obvious in the Crop Sower and Bioreactor where you're likely to lock slots.

If automation, such as a Sophisticated Chest with a hopper upgrade, or Laser IO, is sending items to these machines with locked slots, the machine will allow any item in the slot, not just the locked item. This means the only way to ensure the correct items are in the desired slot is to push them to an inventory and allow the machine to pull from that side.

That's slow, however, and the pull rate doesn't keep up with upgrades.

Industrial Foregoing Version:
3.6.13
Titanium Version:
4.0.21
Crashlog If Applicable (Upload to pastebin/gist):

Kanzaji added a commit to Kanzaji/Titanium that referenced this issue Oct 14, 2024
Can't reproduce original issue - however this fixes insertions to incorrect slots in locked inventories.
Buuz135 pushed a commit to InnovativeOnlineIndustries/Titanium that referenced this issue Nov 1, 2024
* Resolve InnovativeOnlineIndustries/Industrial-Foregoing#1487

* Resolve InnovativeOnlineIndustries/Industrial-Foregoing#1475 + Few Changes

Sided inventories will now correctly check if the slot is valid - The stack limit is now Math.min(StackLimit, SlotLimit)

Sided Inventories will now try to transfer until they insert all items extracted, or until there are no more valid slots.

All IFacingComponents are now called per operation, instead of breaking on the first one that succeeded.

* Possibly Resolve InnovativeOnlineIndustries/Industrial-Foregoing#1473

Can't reproduce original issue - however this fixes insertions to incorrect slots in locked inventories.
@Buuz135 Buuz135 closed this as completed Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants