-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster no-cython implementation of code distance #248
Comments
Stray thought: the pure-numpy implementation above is not really an apples-to-apples comparison with the cython code, because it has extra batching that might make it faster. It might be worth making an apples-to-apples comparison to see whether one of these implementations is significantly faster. Having said that, any implementation that is faster (and not significantly more complex) than the current implementation is worth merging. So the comparison can be left "for future work". |
@richrines1 you want to take credit by opening a draft PR your implementation? |
yeah there's almost definitely a clever way to unify the two paths cleanly - it's just somewhat tricky to get right so splitting it up made it easier to prototype. will think about it a bit more and then open a pr :) |
btw just tried this with numpy 2.1 - brought it down to ~8s for |
See comment by @richrines1.
In the process of adding the implementation above, we should make sure to include:
n
-bit strings for ann
-qubit code), and2n
-bit strings, and weight = symplectic weight).We may as well also use the
popcnt
instruction fromnumpy>=2.0.0
. I'm willing to pushstim/sinter
to push a new release that unblocksnumpy>=2.0.0
🙂The text was updated successfully, but these errors were encountered: