Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] rebase onto newpipe? #634

Closed
2 tasks done
rhjdvsgsgks opened this issue Dec 29, 2024 · 4 comments
Closed
2 tasks done

[Feature request] rebase onto newpipe? #634

rhjdvsgsgks opened this issue Dec 29, 2024 · 4 comments

Comments

@rhjdvsgsgks
Copy link

Checklist (Your issue will be automatically closed if you delete this part)

  • I make sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I believe this feature request will benefit more than 10% of users, not just myself.

hi

could you please rebase pipepipe onto newer version of newpipe? new version of newpipe included some fix already exist on pipepipe. rebase onto them would make difference smaller, and easier to maintain.

if no. please at least cherry pick this TeamNewPipe/NewPipe#11636 . which blocked build on my side for so long. after this i should able to do some contribute to pipepipe

@InfinityLoop1308
Copy link
Owner

There is no plan to rebase. (and it is literally impossible)
Check readme About this fork to see why this is a hard fork.

If you are having problem compiling, simply post your error here or maybe in another discussion so I can help you with that.

@InfinityLoop1308 InfinityLoop1308 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2024
@rhjdvsgsgks
Copy link
Author

If you are having problem compiling, simply post your error here or maybe in another discussion so I can help you with that.

the error i got is IcePick unable to compile on jdk 21 . which already included in the newpipe pr i mentioned above

@InfinityLoop1308
Copy link
Owner

 compileOptions {
        // Flag to enable support for the new language APIs
        coreLibraryDesugaringEnabled true

        sourceCompatibility JavaVersion.VERSION_11
        targetCompatibility JavaVersion.VERSION_11
        encoding 'utf-8'
    }

Don't know why you are expecting a jdk 21. We have no relationship with NewPipe.

@rhjdvsgsgks
Copy link
Author

 compileOptions {
        // Flag to enable support for the new language APIs
        coreLibraryDesugaringEnabled true

        sourceCompatibility JavaVersion.VERSION_11
        targetCompatibility JavaVersion.VERSION_11
        encoding 'utf-8'
    }

Don't know why you are expecting a jdk 21. We have no relationship with NewPipe.

i know that pipepipe and no relationship to newpipe. the reason of why i use jdk 21 is that i dont want to install a old, never used (for other program on my system) jdk just for compiling this application.

even if without jdk version issue. IcePick is still a old, unmaintained project. which should be replaced. especially it using Clojure which make me hard to patch it and make it compile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants