Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently shipping broken fabric server derivations #9

Open
soupglasses opened this issue Aug 22, 2022 · 4 comments
Open

Currently shipping broken fabric server derivations #9

soupglasses opened this issue Aug 22, 2022 · 4 comments
Labels
bug Something isn't working package Topic: Deals with nix-minecraft packages

Comments

@soupglasses
Copy link
Contributor

Current broken fabric servers that i have found are all due to missing vanilla variants.

  • All combat versions.
  • All experimental-snapshot versions.
  • All deep-dark-expermimental-snapshot versions.

I would say we should look into seeing if whitelisting known minecraft versions for fabric in the update.py file. For example, i can currently find the pre, rc, oneblockatatime, Pre-Release, infinite in vanillaServers from a quick look over.

@soupglasses
Copy link
Contributor Author

Luckily quilt-servers packages only recent enough minecraft versions that this is not an issue there currently.

@soupglasses
Copy link
Contributor Author

Also the current fabric-servers/libraries.json ships with multiple empty hashes, causing errors if you try to build these versions.

List:

  • 1.14.2 Pre-Releases
  • 1.14.1 Pre-Releases
  • 1.14 Pre-Releases
  • 3D Shareware v1.34

This is a small enough amount that this may be able to be manually updated.

@Infinidoge
Copy link
Owner

Hmm, I think the better solution for the missing vanilla variants in particular would be to include them, since they should be packaged.

For the empty hashes, yeah they can be done manually (or I suppose completely regenerate libraries/locks).
Might look into making the update script check for empty hashes and regenerate if necessary.

@soupglasses
Copy link
Contributor Author

These are now all building correctly under #11 and will be fixed upstream when the PR gets finalized.

@Infinidoge Infinidoge added the bug Something isn't working label Sep 6, 2022
@Infinidoge Infinidoge added the package Topic: Deals with nix-minecraft packages label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package Topic: Deals with nix-minecraft packages
Projects
None yet
Development

No branches or pull requests

2 participants