Wifi begin(), beginAP() and end() functions #52
Conversation
Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
| #include "time.h" | ||
|
|
||
| #define ARDUINO_MAIN_TASK_STACK_SIZE (4096u) | ||
| #define ARDUINO_MAIN_TASK_PRIORITY (2u) |
There was a problem hiding this comment.
A bit arbitrary. In principle this is the main thread, so this should have a high prio. But not necessarily the highest, as the threads from lwip need to take over (some have 0 prio), and they are not necessarily permanent.
But the thread config is not yet very thoughtfully dimensioned 😅
| */ | ||
| typedef enum { | ||
| WL_NO_SHIELD = 255, | ||
| WL_NO_MODULE = 255, |
There was a problem hiding this comment.
Any reason to keep WL_NO_SHIELD and WL_NO_MODULE both = 255?
There was a problem hiding this comment.
Currently, I just copied the same enums as in the rest of the WiFi Arduino libs.
Given that there is no interface contract standard API for WiFi (as the ArduinoCore-API), I agree it is a good idea to remove them.
If the cy libs has some return code which means "no comm with the transciever" we can map to that ones. Otherwise they will be removed.
| return beginAP(ssid, passphrase, 1); | ||
| } | ||
|
|
||
| uint8_t WiFiClass::beginAP(const char *ssid, const char* passphrase, uint8_t channel) { |
There was a problem hiding this comment.
The documentation for APIs will be added later?
There was a problem hiding this comment.
Yes, I think this should be in our RTD docs as exhale-doxygen generated.
Signed-off-by: jaenrig-ifx <[email protected]>
Signed-off-by: jaenrig-ifx <[email protected]>
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.