Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helix with the latest queries #126

Closed
tgross35 opened this issue Feb 22, 2024 · 4 comments
Closed

Update Helix with the latest queries #126

tgross35 opened this issue Feb 22, 2024 · 4 comments
Labels
compatibility Related to query compatibility

Comments

@tgross35
Copy link
Collaborator

This grammar has gotten quite a bit better and Helix can probably update. The change for this just means bumping the checkout version and updating the queries - the queries in queries-src/ should be what is needed.

It would be great to have some Helix people review those queries too. If they have any changes, please let me know so we can get them upstream.

@tgross35 tgross35 added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 22, 2024
@woojiq
Copy link

woojiq commented Mar 2, 2024

I actually wanted to do this about a month ago, but then I noticed it was crashing, so I put the task on hold. I would like to update queries in the helix repository, but when the injection detection gets better. Does it detect "bash" now as it did in 5766e75..e4e2405 which were reverted?

@tgross35
Copy link
Collaborator Author

tgross35 commented Mar 3, 2024

Hey, thanks for the interest! It currently detects the recipe language via shebangs but does not have a fallback. This is partially because precedence is kind of in a confusing state now - nvim and zed use last-wins, TS just changed to also use last-wins, and helix is hopefully changing pretty soon helix-editor/helix#9436.

But it is easy enough to add, I will do that soon.

@tgross35
Copy link
Collaborator Author

@woojiq I actually went ahead and got this started helix-editor/helix#9850, figured that's probably easiest for the first time since I can make any changes needed here quicker.

@tgross35 tgross35 added compatibility Related to query compatibility and removed help wanted Extra attention is needed good first issue Good for newcomers labels Apr 8, 2024
@tgross35
Copy link
Collaborator Author

My PR was superseded, the update is complete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Related to query compatibility
Projects
None yet
Development

No branches or pull requests

2 participants