Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add inorganic phosphorus pools #663

Closed
jacobcook1995 opened this issue Jan 8, 2025 · 1 comment · Fixed by #672
Closed

add inorganic phosphorus pools #663

jacobcook1995 opened this issue Jan 8, 2025 · 1 comment · Fixed by #672
Assignees

Comments

@jacobcook1995
Copy link
Collaborator

I need to add inorganic phosphorus pools to the soil nutrient model.

This will involve restructuring the code a bit. When I do this I should bear in mind @dalonsoa suggestions for improving the code clarity in the soil pools code.

@jacobcook1995 jacobcook1995 self-assigned this Jan 8, 2025
@davidorme
Copy link
Collaborator

I agree with @dalonsoa's comments about the dataclasses. I think the attribute dot notation is easier to read and the docstrings on the data class provide a cleaner way to explain the structure of what is being stored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants