Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added automerge github workflow #584

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Added automerge github workflow #584

merged 4 commits into from
Oct 10, 2024
+23 −0

Conversation

jacobcook1995
Copy link
Collaborator

Description

This PR copies the automerge workflow that @dalonsoa suggested we could use to automatically merge dependabot and pre-commit pull requests (provided that they pass the CI/QA checks).

I can't think of anyway of testing whether this works (we just have to wait for a dependabot/pre-commit PR). So do let me know if the workflow looks like it'll work.

Fixes #570

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@jacobcook1995 jacobcook1995 linked an issue Oct 10, 2024 that may be closed by this pull request
Add auto merge action for dependabot and pre-commit PRs #570
Closed
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.09%. Comparing base (3c53e4e) to head (d66f6cd).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #584   +/-   ##
========================================
  Coverage    95.09%   95.09%           
========================================
  Files           74       74           
  Lines         4302     4302           
========================================
  Hits          4091     4091           
  Misses         211      211

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

davidorme
davidorme approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidorme davidorme merged commit bb1211c into develop Oct 10, 2024
13 checks passed
@davidorme davidorme deleted the 570-add-auto-merge-action-for-dependabot-and-pre-commit-prs branch October 10, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalonsoa dalonsoa dalonsoa approved these changes

@davidorme davidorme davidorme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add auto merge action for dependabot and pre-commit PRs
4 participants
@jacobcook1995 @codecov-commenter @dalonsoa @davidorme