Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize About box #52

Open
fedorov opened this issue Dec 10, 2020 · 3 comments
Open

Customize About box #52

fedorov opened this issue Dec 10, 2020 · 3 comments

Comments

@fedorov
Copy link
Member

fedorov commented Dec 10, 2020

I think we should do the following:

Can we add a line saying that IDC Viewer is based on / customized fork of the OHIF Viewer, and add a link to upstream?

image

I want to give full credit to OHIF, but I also don't want to confuse the users, and I want the About box to be helpful in tracking down the actual code that is used in the viewer the user is seeing.

@pieper @swederik @Punzo what do you think?

@Punzo
Copy link

Punzo commented Dec 10, 2020

I think the changes make sense, and regarding the credit a line to give credit to OIHF is reasonable. Maybe in the credit line should be present the link of the OIHF master repo? what do you think @igoroctaviano, @swederik and @andrebot?

@igoroctaviano
Copy link
Collaborator

Makes sense, i would change Version Number => OHIF Version Number or maybe create a new section below the current one and name it OHIF Version Information?

@fedorov
Copy link
Member Author

fedorov commented Dec 10, 2020

Makes sense, i would change Version Number => OHIF Version Number or maybe create a new section below the current one and name it OHIF Version Information?

Yes, I think it is important to know both the upstream base version, and the specific fork version used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants