Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secondary DICOM server parameter for IDC viewer handler #24

Open
fedorov opened this issue Jan 3, 2024 · 3 comments
Open

Add secondary DICOM server parameter for IDC viewer handler #24

fedorov opened this issue Jan 3, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@fedorov
Copy link
Member

fedorov commented Jan 3, 2024

This is follow up on vkt1414/slicer-idc-viewer#2.

@pieper I thought about this after the discussion yesterday. I understand the use case better now, and I think adding the feature that would allow parameterizing slicer://idc-viewer/ with a DICOMweb endpoint is a specific functionality we could explore towards implementing the workflow in the issue above. I initially thought it would be better to have this handler in mpReview, but since most of the logic will be in IDCBrowser, it makes more sense to implement it here.

I think the functionality would be the following:

  • idc-viewer handler is passed a list of SeriesInstanceUIDs as one parameter
  • and the GCP DICOMweb URL as the second parameter
  • handler uses idc-index to resolve StudyInstanceUID for each of the SeriesInstanceUIDs and fetches all of the available series in those studies using DICOMweb from the secondary server

We should reuse the functionality from SlicerDICOMWeb, similar to how it is done in mpReview in https://github.com/SlicerProstate/mpReview/blob/master/mpReview.py#L534-L543 and https://github.com/SlicerProstate/mpReview/blob/master/mpReview.py#L1814.

Is this consistent with what you were looking for @pieper? I was confused by the other issue since it was very broad.

I think we should look into this only after the basic handler is functional.

@fedorov fedorov added the enhancement New feature or request label Jan 3, 2024
@pieper
Copy link
Member

pieper commented Jan 3, 2024

Yes, thanks @fedorov that sounds like a very useful feature to support the use case we discussed.

@pieper
Copy link
Member

pieper commented Jan 3, 2024

Do we have a place where the slicer:// url parameter schema is documented where we can add info about these new fields?

@fedorov
Copy link
Member Author

fedorov commented Jan 3, 2024

No, we don't. I think we can start discussing this whenever @vkt1414 has the PR opened. But for now I want to focus on TotalSegmentator project and make a push to try to get it done before the PW. I think we can use PW project for ironing out details like the schema and this new functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants